New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve the timing when to check empty of panels #233

Merged

wewoor merged 1 commit into main from fix/collapse

Jul 13, 2021

Collaborator

mortalYoung commented Jul 12, 2021

简介

修复在先打开文件树的情况下，无法打开 outline 的问题

主要变更

主要原因是因为去判断 panel 是否 empty 的时机不对，calcPosition 函数的执行依赖于所有 panel 的 isEmpty 属性，所以在第一个 panel 去执行该函数前就应该把所有的 panels 的 isEmpty 状态更新掉，而不是之前在每一个 panel 计算之前再去更新状态


          fix: improve the timing when to check empty of panels

eb8c8bf

wewoor merged commit 5ef6a82 into main

wewoor deleted the fix/collapse branch

July 13, 2021 01:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet