Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent page broken when data is undefined #361

Merged
merged 1 commit into from
Aug 25, 2021
Merged

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 防止新建 tree 的时候由于没有 data 属性,导致页面崩溃

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #361 (66426f7) into main (02da8bb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #361   +/-   ##
=======================================
  Coverage   59.61%   59.61%           
=======================================
  Files         173      173           
  Lines        4635     4635           
  Branches     1021     1021           
=======================================
  Hits         2763     2763           
  Misses       1852     1852           
  Partials       20       20           
Impacted Files Coverage Δ
src/workbench/sidebar/explore/editorTree.tsx 12.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02da8bb...66426f7. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor added this to the 0.9.0-alpha.5 milestone Aug 25, 2021
@wewoor wewoor added the bug Something isn't working label Aug 25, 2021
@wewoor wewoor merged commit 26d611a into main Aug 25, 2021
@wewoor wewoor deleted the fix/editorTree branch August 25, 2021 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants