Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support to get groupId via tabId #431

Merged
merged 1 commit into from
Sep 15, 2021
Merged

feat: support to get groupId via tabId #431

merged 1 commit into from
Sep 15, 2021

Conversation

mortalYoung
Copy link
Collaborator

简介

  • 支持通过 tabId 获取到该 tab 所属的 groupId

@mortalYoung mortalYoung self-assigned this Sep 15, 2021
@codecov
Copy link

codecov bot commented Sep 15, 2021

Codecov Report

Merging #431 (89e3de2) into main (0a5c31d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
+ Coverage   81.06%   81.09%   +0.03%     
==========================================
  Files         177      177              
  Lines        4874     4882       +8     
  Branches     1050     1052       +2     
==========================================
+ Hits         3951     3959       +8     
  Misses        914      914              
  Partials        9        9              
Impacted Files Coverage Δ
src/services/workbench/editorService.ts 97.99% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a5c31d...89e3de2. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 44c2a7b into main Sep 15, 2021
@wewoor wewoor deleted the feat/editor branch September 15, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants