Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the tsyringe inject the EditorModel error #468

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix: the tsyringe inject the EditorModel error #468

merged 1 commit into from
Oct 13, 2021

Conversation

wewoor
Copy link
Collaborator

@wewoor wewoor commented Oct 12, 2021

Description

修复 EditorModel 注入时初始化失败的问题

Changes

  • 移除 EditorModel 中初始值 undefined 的设计

@wewoor wewoor requested a review from mortalYoung October 12, 2021 09:49
@wewoor wewoor added this to the 0.9.0-alpha.6 milestone Oct 12, 2021
@wewoor wewoor added the bug Something isn't working label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #468 (a36f57f) into main (2942a8e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #468   +/-   ##
=======================================
  Coverage   81.26%   81.26%           
=======================================
  Files         181      181           
  Lines        5072     5072           
  Branches     1112     1112           
=======================================
  Hits         4122     4122           
  Misses        941      941           
  Partials        9        9           
Impacted Files Coverage Δ
src/model/workbench/editor.ts 96.96% <100.00%> (ø)
src/services/notificationService.ts 100.00% <0.00%> (ø)
src/services/helper.ts
src/common/treeUtil.ts 100.00% <0.00%> (ø)
src/common/utils.ts 85.18% <0.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2942a8e...a36f57f. Read the comment docs.

@wewoor wewoor self-assigned this Oct 12, 2021
Copy link
Collaborator

@mortalYoung mortalYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit fbb4113 into main Oct 13, 2021
@wewoor wewoor deleted the fix/editor branch October 13, 2021 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants