-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add built-in service #471
Conversation
3bb6aa0
to
5b2ea1e
Compare
Codecov Report
@@ Coverage Diff @@
## main #471 +/- ##
==========================================
+ Coverage 81.81% 85.10% +3.28%
==========================================
Files 178 179 +1
Lines 5109 5183 +74
Branches 1110 1178 +68
==========================================
+ Hits 4180 4411 +231
+ Misses 920 763 -157
Partials 9 9
Continue to review full report at Codecov.
|
覆盖率达大降的原因是因为,我取消了部分 |
终于过了 🤣 |
@@ -53,6 +54,7 @@ export class FolderTreeController | |||
|
|||
const fileContextMenu = this.folderTreeService.getFileContextMenu(); | |||
const folderContextMenu = this.folderTreeService.getFolderContextMenu(); | |||
const { ROOT_FOLDER_CONTEXT_MENU } = this.builtinService.getModules(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我们可以把 modules 和 constants 的命名区分下,不然会看起来比较奇怪,这里会怀疑获取的是一个不同的 Constant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确实,命名是这个 PR 里面直接改了吗,还是说另起一个 PR 改?我个人倾向于另起一个 0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
重启一个吧,我重开一个 issue #475
简介
主要变更