Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use css to control the display and hiding of modules under workbench #564

Merged
merged 3 commits into from
Dec 23, 2021

Conversation

kiwiwong
Copy link
Collaborator

Description

Use css to control the display and hiding of modules under workbench.
Optimize the style of MenuBar in horizontal mode.

Fixes #562

Changes

  • Added the Display component.
  • The module that originally used conditional rendering under the workbench was changed to use the Display component to wrap.
  • Adjusted the height and font size of MenuBar in horizontal mode.

@kiwiwong kiwiwong added the enhancement New feature or request label Dec 22, 2021
@kiwiwong kiwiwong self-assigned this Dec 22, 2021
@codecov
Copy link

codecov bot commented Dec 22, 2021

Codecov Report

Merging #564 (46c8055) into main (1ee89ba) will increase coverage by 0.50%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   86.77%   87.27%   +0.50%     
==========================================
  Files         189      190       +1     
  Lines        5571     5571              
  Branches     1245     1241       -4     
==========================================
+ Hits         4834     4862      +28     
+ Misses        727      699      -28     
  Partials       10       10              
Impacted Files Coverage Δ
src/components/display/index.tsx 100.00% <100.00%> (ø)
src/workbench/workbench.tsx 100.00% <100.00%> (ø)
src/extensions/locales-defaults/index.ts 90.00% <0.00%> (+1.11%) ⬆️
src/controller/activityBar.ts 80.35% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ee89ba...46c8055. Read the comment docs.

@wewoor wewoor removed the request for review from mumiao December 23, 2021 02:46
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor added this to the 0.9.0-beta.2 milestone Dec 23, 2021
@wewoor wewoor merged commit 948f09c into main Dec 23, 2021
@wewoor wewoor deleted the feat/displayComp branch December 23, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The module under workbench uses CSS to control display and hiding
2 participants