Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize the interaction of MenuBar in horizontal mode #636

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

kiwiwong
Copy link
Collaborator

@kiwiwong kiwiwong commented Jan 20, 2022

Description

Optimize the interaction of MenuBar in horizontal mode

Fixes #625

Changes

  • For the MenuBar in horizontal mode, extract the HorizontalView component.
  • Change the interaction of MenuBar in horizontal mode to be similar to VSCode.
  • Add unit test code.

@kiwiwong kiwiwong self-assigned this Jan 20, 2022
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #636 (bcd1e59) into main (d45a807) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
+ Coverage   89.02%   89.09%   +0.07%     
==========================================
  Files         184      185       +1     
  Lines        5412     5447      +35     
  Branches     1222     1229       +7     
==========================================
+ Hits         4818     4853      +35     
  Misses        586      586              
  Partials        8        8              
Impacted Files Coverage Δ
src/workbench/menuBar/menuBar.tsx 96.96% <ø> (-0.65%) ⬇️
src/workbench/menuBar/horizontalView.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d45a807...bcd1e59. Read the comment docs.

@kiwiwong kiwiwong changed the title improve: the interaction of MenuBar in horizontal mode feat: optimize the interaction of MenuBar in horizontal mode Jan 20, 2022
Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit b352afd into main Jan 20, 2022
@wewoor wewoor deleted the feat/menuBar-interaction branch January 20, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve: menuBar interactive
2 participants