Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the context menu does not close when the context menu item is clicked. #651

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

kiwiwong
Copy link
Collaborator

Description

Fix the issue that the onClick property of MenuItem will be overridden by custom data.

@kiwiwong kiwiwong added the bug Something isn't working label Feb 11, 2022
@kiwiwong kiwiwong self-assigned this Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #651 (7fca00c) into main (2294b3d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #651   +/-   ##
=======================================
  Coverage   89.34%   89.34%           
=======================================
  Files         185      185           
  Lines        5613     5613           
  Branches     1332     1332           
=======================================
  Hits         5015     5015           
  Misses        590      590           
  Partials        8        8           
Impacted Files Coverage Δ
src/components/menu/menu.tsx 86.53% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2294b3d...7fca00c. Read the comment docs.

Copy link
Collaborator

@wewoor wewoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wewoor wewoor merged commit 467a7c0 into main Feb 15, 2022
@wewoor wewoor deleted the fix/menuItem branch February 15, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants