forked from WebKit/WebKit
-
Notifications
You must be signed in to change notification settings - Fork 0
/
Copy pathChangeLog
11040 lines (6788 loc) · 367 KB
/
ChangeLog
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
2022-04-01 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] Enable CSS Typed OM by default
https://bugs.webkit.org/show_bug.cgi?id=238659
Reviewed by Adrian Perez de Castro.
Always build with Typed OM enabled, it's handled by an off by default setting.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-31 Don Olmstead <don.olmstead@sony.com>
[PlayStation] Enable more features by default
https://bugs.webkit.org/show_bug.cgi?id=238628
Reviewed by Fujii Hironori.
Move ENABLE_WEB_CRYPTO and add ENABLE_NETWORK_CACHE_SPECULATIVE_REVALIDATION
and ENABLE_NETWORK_CACHE_STALE_WHILE_REVALIDATE to the list of features on by default.
* Source/cmake/OptionsPlayStation.cmake:
2022-03-31 Don Olmstead <don.olmstead@sony.com>
[PlayStation] Enable WebDriver
https://bugs.webkit.org/show_bug.cgi?id=238615
Reviewed by Alex Christensen.
Enable WebDriver by default. Set values for input interactions.
* Source/cmake/OptionsPlayStation.cmake:
2022-03-30 Don Olmstead <don.olmstead@sony.com>
Turn DEVELOPER_MODE ON for all non-Apple ports in build-webkit
https://bugs.webkit.org/show_bug.cgi?id=238556
Reviewed by Alex Christensen.
Use DEVELOPER_MODE to determine what the defaults of ENABLE_API_TESTS and
ENABLE_MINIBROWSER should be. Make ENABLE_WEBKIT the default of ENABLE_MINIBROWSER.
* Source/cmake/OptionsPlayStation.cmake:
2022-03-29 Ryosuke Niwa <rniwa@webkit.org>
Add descriptions on how to start WPT and http test servers to Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=238523
Reviewed by Chris Dumez.
* Introduction.md:
2022-03-29 Don Olmstead <don.olmstead@sony.com>
[LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
https://bugs.webkit.org/show_bug.cgi?id=238510
Reviewed by Adrian Perez de Castro.
Post v1.12.0 introduces the WPE_ENABLE_XKB definition to libwpe. For v1.12.0 and earlier
the define is added to the WPE::libwpe target's compile options. For later versions the
pkg-config for the library will determine the presence of this definition.
* Source/cmake/FindWPE.cmake:
2022-03-26 Aakash Jain <aakash_jain@apple.com>
Update my github username.
Unreviewed.
* metadata/contributors.json:
2022-03-22 Per Arne Vollan <pvollan@apple.com>
REGRESSION(r291587): Unintentionally removed contributors change
https://bugs.webkit.org/show_bug.cgi?id=238204
Unreviewed, partial revert of r291587.
* metadata/contributors.json:
2022-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] Remove the ATK implementation
https://bugs.webkit.org/show_bug.cgi?id=238198
Reviewed by Adrian Perez de Castro.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-21 Commit Queue <commit-queue@webkit.org>
Unreviewed, reverting r291055.
https://bugs.webkit.org/show_bug.cgi?id=238145
Invalid test expectations
Reverted changeset:
"[iOS] Hard link AVPictureInPictureController"
https://bugs.webkit.org/show_bug.cgi?id=237227
https://commits.webkit.org/r291055
2022-03-18 Philippe Normand <pnormand@igalia.com>
[GStreamer] Migrate gst-full support to 1.20
https://bugs.webkit.org/show_bug.cgi?id=237772
Reviewed by Xabier Rodriguez-Calvar.
* Source/cmake/GStreamerChecks.cmake:
2022-03-18 Philippe Normand <pnormand@igalia.com>
[GStreamer] Initial import of the GstWebRTC backend
https://bugs.webkit.org/show_bug.cgi?id=236540
Reviewed by Carlos Garcia Campos and Xabier Rodriguez-Calvar.
Enable GstWebRTC by default if a recent-enough (>= 1.20) version is available.
* Source/cmake/FindGStreamer.cmake:
* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/GStreamerDependencies.cmake:
2022-03-18 Carlos Garcia Campos <cgarcia@igalia.com>
Add a public build option for PDF.js
https://bugs.webkit.org/show_bug.cgi?id=238023
Reviewed by Michael Catanzaro.
PDF.js increases the binary size of the library quite a bit, so embedders might want to disable it if they know
they don't need PDF support at all.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Source/cmake/WebKitFeatures.cmake:
2022-03-17 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Also enable USE_TEXTURE_MAPPER_DMABUF alongside other DMABuf-related defines
https://bugs.webkit.org/show_bug.cgi?id=238017
Reviewed by Alejandro G. Castro.
For the GTK port, define USE_TEXTURE_MAPPER_DMABUF alongside the
dependencies and defines for DMABuf-backed ANGLE integration. This will
enable usage of the DMABuf-based video sink in any GStreamer pipeline
and subsequently display of the provided DMABuf objects. A comment is
added to explain this should be covered by a separate configuration
option on which USE_ANGLE_WEBGL should then depend.
For the WPE port the define is also added but without conditions, just
like it's done for the dependencies and the USE_LIBGBM define.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-17 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Guard libgbm and libdrm code, make them conditional dependencies for GTK
https://bugs.webkit.org/show_bug.cgi?id=237974
Reviewed by Alejandro G. Castro.
Guard usage of libgbm and libdrm dependencies with the USE_LIBGBM
define. This should be required until we can switch to a possibly more
dynamic implementation that doesn't require build-time dependencies.
For the GTK port, the desire is to keep these dependencies fully
optional. At the moment they are required when enabling ANGLE-backed
WebGL, with the USE_LIBGBM also defined in that case. This is needed
because ANGLE integration for Linux ports already depends on these
libraries.
For the WPE port only USE_LIBGBM is defined and the two dependencies
remain required.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-03-14 Gabriel Nava Marino <gnavamarino@apple.com>
Add myself (Gabriel Nava Marino) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237634
Unreviewed.
* metadata/contributors.json:
2022-03-11 Elliott Williams <emw@apple.com>
Makefile.shared: Rename WORKSPACE to WORKSPACE_PATH and allow overrides
https://bugs.webkit.org/show_bug.cgi?id=237746
Reviewed by Alexey Proskuryakov.
This permits Make-based workflows which build out of a different workspace, e.g. a workspace
that includes WebKitAdditions.
WORKSPACE_PATH was chosen as a new name for parity with SCRIPTS_PATH and to avoid confusion
with USE_WORKSPACE.
Refactors Makefile.shared a bit to prevent SCHEME or WORKSPACE_PATH being set without
USE_WORKSPACE from breaking the build.
* Makefile.shared:
2022-03-08 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Support multiple metadata locations
https://bugs.webkit.org/show_bug.cgi?id=237395
<rdar://problem/89715863>
Reviewed by Dewei Zhu.
* metadata/git_config_extension: Renamed from metadata/project_config.
* metadata/project_config: Renamed to metadata/git_config_extension.
2022-03-10 Elliott Williams <emw@apple.com>
[XCBuild] Fix GeneratedSources dependency validation errors
https://bugs.webkit.org/show_bug.cgi?id=237490
Reviewed by Alexey Proskuryakov.
Fixes miscellanous targets which were not specifying their task outputs correctly.
For easier dependency validation testing, Make builds now recognize a VALIDATE_DEPENDENCIES
setting. Building with VALIDATE_DEPENDENCIES=YES or VALIDATE_DEPENDENCIES=YES_ERROR passes
the setting to xcodebuild and sets a magic xattr on the build directory so that product
files in it are validated.
* Makefile.shared:
2022-03-07 Basuke Suzuki <basuke.suzuki@sony.com>
Update Basuke Suzuki's status to reviewer
https://bugs.webkit.org/show_bug.cgi?id=237545
Unreviewed.
* metadata/contributors.json:
2022-03-07 Jonathan Bedard <jbedard@apple.com>
[webkitbugspy] Allow creation of new issues
https://bugs.webkit.org/show_bug.cgi?id=237123
<rdar://problem/89388181>
Reviewed by Dewei Zhu.
* metadata/trackers.json: Define project.
2022-03-03 Dan Glastonbury <djg@apple.com>
Add Dan Glastonbury's name to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237453
Reviewed by Alan Bujtas.
* metadata/contributors.json:
2022-03-03 Anjali Kumar <anjalik_22@apple.com>
Add myself (Anjali Kumar) to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237449
Reviewed by Patrick Angle.
* metadata/contributors.json: Added myself.
2022-03-01 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Sync personal fork by default
https://bugs.webkit.org/show_bug.cgi?id=237324
<rdar://problem/89618617>
Reviewed by Dewei Zhu.
* metadata/project_config: Add webkitscmpy.update-fork option.
2022-03-02 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Build failure with libstdc++ (>= 6) when cross-compiling (fatal error: stdlib.h: No such file or directory)
https://bugs.webkit.org/show_bug.cgi?id=161697
<rdar://problem/89613152>
Reviewed by Carlos Garcia Campos.
* Source/cmake/WebKitCompilerFlags.cmake: Go through CMake instead of the plain "env"
program for the sake of portability.
2022-03-01 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Build failure with libstdc++ (>= 6) when cross-compiling (fatal error: stdlib.h: No such file or directory)
https://bugs.webkit.org/show_bug.cgi?id=161697
Reviewed by Carlos Garcia Campos.
* Source/cmake/WebKitCompilerFlags.cmake: Set LANG=C in compiler invocation to ensure its
output is consistent and the checks are independent from the system locale configuration.
2022-03-01 Basuke Suzuki <basuke.suzuki@sony.com>
[CMake] Disabling ENABLE_WEBCORE is ignored when cmake configuration runs again.
https://bugs.webkit.org/show_bug.cgi?id=237170
Reviewed by Fujii Hironori.
CMake variables which has chance to set from outside should be cached in CMake configuration cache.
Unless cacheing, the result of building the generated project is not consisitent because the other
configuration may run while building.
To make it complete, I've changed ENABLE_JAVASCRIPTCORE, ENABLE_WEBCORE and ENABLE_WEBKIT to `option()`
which is stored in cached and reused while building even if the confuguration runs again.
* Source/cmake/OptionsPlayStation.cmake:
* Source/cmake/WebKitCommon.cmake:
2022-02-28 Brandon Stewart <brandonstewart@apple.com>
Add Brandon Stewart's name to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237288
Reviewed by Saam Barati.
Add Brandon Stewart's name to contributors.json
* metadata/contributors.json:
2022-02-28 Michael Catanzaro <mcatanzaro@gnome.org>
-Wodr warning spam caused by ENABLE(BINDING_INTEGRITY)
https://bugs.webkit.org/show_bug.cgi?id=229867
<rdar://problem/82975115>
Reviewed by Carlos Garcia Campos.
Build WebKit with -Wno-odr. This warning is not salvagable, and it's impossible to suppress
locally.
* Source/cmake/WebKitCompilerFlags.cmake:
2022-02-24 Matt Woodrow <mattwoodrow@apple.com>
Unreviewed, update my (Matt Woodrow) status to committer.
* metadata/contributors.json:
2022-02-25 Zan Dobersek <zdobersek@igalia.com>
[GTK][WPE] Uncouple libgbm, libdrm dependencies from ANGLE functionality
https://bugs.webkit.org/show_bug.cgi?id=237199
Reviewed by Chris Lord.
For both GTK and WPE, unconditionally search for the libgbm and libdrm
dependencies as they will also be needed outside of ANGLE functionality.
USE_ANGLE is defined along with USE_NICOSIA, but still only if the
relevant option was enabled.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-25 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. [GTK] Bump version numbers
* Source/cmake/OptionsGTK.cmake:
2022-02-24 Ryosuke Niwa <rniwa@webkit.org>
Explain visit children and opaque roots in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=236894
Reviewed by Saam Barati.
Added the descriptions of visit children and opaque roots
as well as how to add IDL files.
* Introduction.md:
2022-02-23 Elliott Williams <emw@apple.com>
[XCBuild] Don't automatically use the ../Internal/WebKit workspace
https://bugs.webkit.org/show_bug.cgi?id=237115
Reviewed by Alexey Proskuryakov.
When the USE_WORKSPACE=YES Make flag was added in https://commits.webkit.org/246232@main, we
configured Make to automatically use the workspace at ../Internal/WebKit/WebKit.xcworkspace,
if it was available. The idea was to make it easier for workspace builds to automatically
detect dependencies needed by folks at Apple, like WebKitAdditions.
In practice, this has made workspace builds silently rely on code from outside of the WebKit
repo, and it's unintuitive since non-workspace Make builds do not do this.
* Makefile.shared:
2022-02-23 W.D. Xiong <wdx@apple.com>
Add wdx's Github username to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=237106
Unreviewed.
* metadata/contributors.json:
2022-02-23 Zan Dobersek <zdobersek@igalia.com>
[GStreamer] Add WebKitDMABufVideoSink
https://bugs.webkit.org/show_bug.cgi?id=236883
Reviewed by Philippe Normand.
* Source/cmake/FindGStreamer.cmake:
Also search for gstreamer-allocators-1.0, produce the relevant variables
containing include directories and cflags.
2022-02-22 Philippe Normand <pnormand@igalia.com>
[GStreamer] Initial MediaRecorder implementation
https://bugs.webkit.org/show_bug.cgi?id=236558
Reviewed by Xabier Rodriguez-Calvar.
Enable MediaRecorder support if GStreamer >= 1.20 is available.
* Source/cmake/FindGStreamer.cmake:
* Source/cmake/GStreamerChecks.cmake:
* Source/cmake/GStreamerDefinitions.cmake:
* Source/cmake/GStreamerDependencies.cmake:
2022-02-21 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] ANGLE: make USE_ANGLE_WEBGL build option public
https://bugs.webkit.org/show_bug.cgi?id=236962
Reviewed by Chris Lord.
Since it introduces new dependencies, the build option should be public and a fatal error message should be
shown when the option is enabled and any for the dependencies is missing.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-20 Brandon Stewart <brandonstewart@apple.com>
Generate compile_commands.json on macOS Builds
https://bugs.webkit.org/show_bug.cgi?id=235686
Reviewed by Saam Barati.
Add support for generating compile_commands.json file to WebKit.
compile_commands.json can be used by tools like clangd to provide code complete,
refactoring, formatting, and cross references.
Steps to generate the compile commands file:
make d EXPORT_COMPILE_COMMANDS=YES
generate-compile-commands WebKitBuild/Debug
* Makefile.shared:
2022-02-19 Philippe Normand <pnormand@igalia.com>
[WPE][GTK] Enable Thunder and remove old Clearkey CDM/Decryptor
https://bugs.webkit.org/show_bug.cgi?id=235492
Reviewed by Xabier Rodriguez-Calvar.
Enable Thunder in developer builds, this is now needed for the clearkey EME layout tests.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-18 Robert Jenner <Jenner@apple.com>
Unreviewed, reverting r290149.
Broke Debug Builds.
Reverted changeset:
"Generate compile_commands.json on macOS Builds"
https://bugs.webkit.org/show_bug.cgi?id=235686
https://commits.webkit.org/r290149
2022-02-18 Ryosuke Niwa <rniwa@webkit.org>
Replace trac URLs in Introduction.md by equivalent GitHub URLs
https://bugs.webkit.org/show_bug.cgi?id=236826
Reviewed by Sihui Liu.
Replaced track links by equivalent Github links in Introduction.md.
Also replaced an example of a reference test since the previously referenced test
had been converted to a manual test, and updated documentations around preferences
as they had been refactored since this was originally written.
* Introduction.md:
2022-02-18 Brandon Stewart <brandonstewart@apple.com>
Generate compile_commands.json on macOS Builds
https://bugs.webkit.org/show_bug.cgi?id=235686
Reviewed by Saam Barati.
Add support for generating compile_commands.json file to WebKit.
compile_commands.json can be used by tools like clangd to provide code complete,
refactoring, formatting, and cross references.
Steps to generate the compile commands file:
make r EXPORT_COMPILE_COMMANDS=YES
generate-compile-commands WebKitBuild/Release
* Makefile.shared:
2022-02-18 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc
https://bugs.webkit.org/show_bug.cgi?id=236592
Reviewed by Michael Catanzaro.
* Source/cmake/FindOpenGL.cmake: Rewrite to use imported targets, try the "opengl" and "glx"
pkg-config modules first, otherwise keep the existing logic that tried the "gl" pkg-config
module with fallbacks to find_path/find_library.
* Source/cmake/OptionsGTK.cmake: Check for the presence of the OpenGL::GLX target instead of
te GLX_FOUND variable.
2022-02-17 Commit Queue <commit-queue@webkit.org>
Unreviewed, reverting r289949.
https://bugs.webkit.org/show_bug.cgi?id=236757
Breaks WPE builds with -DUSE_ANGLE_WEBGL=ON
Reverted changeset:
"[CMake] Cannot find OpenGL when system provides opengl.pc
instead of gl.pc"
https://bugs.webkit.org/show_bug.cgi?id=236592
https://commits.webkit.org/r289949
2022-02-16 Don Olmstead <don.olmstead@sony.com>
[CMake][PlayStation] Add find module for WPE Backend for PlayStation
https://bugs.webkit.org/show_bug.cgi?id=236721
Reviewed by Michael Catanzaro.
Add the find module to detect the presence of the WPE Backend for PlayStation platforms.
Currently its not required to have the WPE Backend so its presence is conditional. When
there USE(WPE_BACKEND_PLAYSTATION) will be true.
* Source/cmake/FindWPEBackendPlayStation.cmake: Added.
* Source/cmake/OptionsPlayStation.cmake:
2022-02-16 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Cannot find OpenGL when system provides opengl.pc instead of gl.pc
https://bugs.webkit.org/show_bug.cgi?id=236592
Reviewed by Don Olmstead.
* Source/cmake/FindOpenGL.cmake: Rewrite to use imported targets, try the "opengl" and "glx"
pkg-config modules first, otherwise keep the existing logic that tried the "gl" pkg-config
module with fallbacks to find_path/find_library.
* Source/cmake/OptionsGTK.cmake: Check for the presence of the OpenGL::GLX target instead of
te GLX_FOUND variable.
2022-02-15 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Checks uses of execute_process() for correct command splitting
https://bugs.webkit.org/show_bug.cgi?id=236366
Reviewed by Don Olmstead.
* Source/cmake/FindGObjectIntrospection.cmake: Remove macro _GIR_GET_PKGCONFIG_VAR, which used
execute_process(), in favor of pkg_get_variable(), which has been supported since CMake 3.4
2022-02-11 Don Olmstead <don.olmstead@sony.com>
[CMake] Check for MAP_ALIGNED support
https://bugs.webkit.org/show_bug.cgi?id=236522
Reviewed by Keith Miller.
Add a symbol check for MAP_ALIGNED in the CMake.
* Source/cmake/OptionsCommon.cmake:
2022-02-11 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Use ld.lld by default for development builds where available
https://bugs.webkit.org/show_bug.cgi?id=235979
Reviewed by Michael Catanzaro.
* Source/cmake/OptionsCommon.cmake: Enable USE_LD_LLD by default for developers builds
when ld.lld is available. While at it, improve the match on LD_VERSION to be more robust.
2022-02-10 Filip Pizlo <fpizlo@apple.com>
Unreviewed, add an alternate email address.
* metadata/contributors.json:
2022-02-10 Elliott Williams <emw@apple.com>
[Xcode] Perform a full build when analyzing
https://bugs.webkit.org/show_bug.cgi?id=236421
Reviewed by Alexey Proskuryakov.
`xcodebuild analyze` does just enough work to run the analyzer on each target, and doesn't
appear to run build phases that only impact consumers of the target. In particular, it
doesn't copy framework headers.
Fix by telling xcodebuild to build _and_ analyze at once. AFAICT, this is exactly what
Xcode's Product > Analyze command does.
* Makefile.shared: s/analyze/build analyze
2022-02-10 Alejandro G. Castro <alex@igalia.com>
[GTK][WPE] Improve device detection in the GbmDevice
https://bugs.webkit.org/show_bug.cgi?id=236436
Reviewed by Chris Lord.
* Source/cmake/OptionsGTK.cmake: Search for drm and gbm libraries
when compiling WebGL ANGLE support.
* Source/cmake/OptionsWPE.cmake: Ditto.
2022-02-10 Tim Nguyen <ntim@apple.com>
Unreviewed, update my (Tim Nguyen) status to reviewer
* metadata/contributors.json:
2022-02-09 Ross Kirsling <ross.kirsling@sony.com>
SharedMemoryUnix should use SHM_ANON when available
https://bugs.webkit.org/show_bug.cgi?id=236416
Reviewed by Don Olmstead.
* Source/cmake/OptionsCommon.cmake: Check for SHM_ANON.
2022-02-09 Adrian Perez de Castro <aperez@igalia.com>
[CMake] REGRESSION(r288994): Setting multiple values in LDFLAGS causes incorrect linker detection
https://bugs.webkit.org/show_bug.cgi?id=236365
Reviewed by Martin Robinson.
* Source/cmake/OptionsCommon.cmake: Use separate_arguments() to turn plain command strings
into lists of strings, which can then be passed down to execute_process() as it knows how
to handle lists properly.
2022-02-09 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.3 release
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
2022-02-08 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Allow repositories to declare their bug trackers
https://bugs.webkit.org/show_bug.cgi?id=236306
<rdar://problem/88633018>
Reviewed by Dewei Zhu.
* metadata/trackers.json: Added.
2022-02-08 Adrian Perez de Castro <aperez@igalia.com>
[WPE] Running distcheck with USE_SOUP2=OFF fails to install documentation
https://bugs.webkit.org/show_bug.cgi?id=236235
Reviewed by Carlos Garcia Campos.
* Source/PlatformWPE.cmake: Use WPE_API_DOC_VERSION instead of WPE_API_VERSION for the documentation.
2022-02-07 Adrian Perez de Castro <aperez@igalia.com>
[CMake] REGRESSION(r288994): Linker does not get passed --disable-new-dtags
https://bugs.webkit.org/show_bug.cgi?id=236205
Reviewed by Darin Adler.
* Source/cmake/OptionsCommon.cmake: Arrange passing --disable-new-dtags to linkers that
are known to support the option. While at it, reorganize a bit how detected linker/archiver
features are printed out for better readability.
2022-02-03 Myles C. Maxfield <mmaxfield@apple.com>
Two bopomofo tone marks are not moved to the correct place in vertical text with a particular bopomofo font
https://bugs.webkit.org/show_bug.cgi?id=235257
<rdar://problem/87625596>
Reviewed by Darin Adler.
Thank you so much to Bobby Tung and But Ko for reporting this bug and providing a test font for it!!!
* metadata/contributors.json:
2022-02-03 Elliott Williams <emw@apple.com>
Add Elliott Williams to contributors.json
Unreviewed.
* metadata/contributors.json:
2022-01-24 Jonathan Bedard <jbedard@apple.com>
[git-webkit] Configure default branch management
https://bugs.webkit.org/show_bug.cgi?id=235378
<rdar://problem/87989533>
Reviewed by Dewei Zhu.
* metadata/project_config: Added.
2022-02-03 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.35.2 release
* Source/cmake/OptionsGTK.cmake: Bump version numbers.
2022-02-02 Carlos Garcia Campos <cgarcia@igalia.com>
Unreviewed. [GTK] Apply the same cmake changes of r289029 to GTK port
* Source/cmake/OptionsGTK.cmake:
2022-02-02 Pablo Saavedra <psaavedra@igalia.com>
[WPE] Fix for non-unified builds with ACCESSIBILITY=OFF
https://bugs.webkit.org/show_bug.cgi?id=236024
Reviewed by Darin Adler.
* Source/cmake/OptionsWPE.cmake:
2022-02-02 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Stop defaulting to ld.gold
https://bugs.webkit.org/show_bug.cgi?id=235476
Reviewed by Michael Catanzaro.
Remove the USE_LD_GOLD option, and let the build use by default the system linker.
The output from running the linker with -Wl,--version is matched to determine which linker
is currently in use, and set variables LD_SUPPORTS_<feature> accordingly. This is needed
because not all of them support certain features and after a few attempts at doing feature
checks it was becoming clear that on one hand the checks were getting gnarly, and on the
other hand vetting certain linkers provides a stronger guarantee of sucessful builds.
Similarly, extend the check used to determine whether the static library archiver supports
thin archivers to cover the one included with LLVM (llvm-ar), and enable usage of think
archivers if they can be both created by the archiver and consumed by the linker. Previously
the build system was enabling thin archives without knowing whether the linker would succeed
using them.
* Source/cmake/OptionsCommon.cmake:
2022-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][WPE] Switch to use ATSPI instead of ATK
https://bugs.webkit.org/show_bug.cgi?id=235942
Reviewed by Adrian Perez de Castro.
Use ATSPI by default.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-02-01 Tim Nguyen <ntim@apple.com>
Entirely remove support for -apple-trailing-word
https://bugs.webkit.org/show_bug.cgi?id=234672
Reviewed by Simon Fraser.
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:
2022-01-28 Elliott Williams <emw@apple.com>
[XCBuild] Small corrections to build-webkit and Makefile for workspace builds
https://bugs.webkit.org/show_bug.cgi?id=235747
Reviewed by Alexey Proskuryakov.
* Makefile: Set SCRIPTS_PATH correctly from the root of the repo
2022-01-28 Pablo Saavedra <psaavedra@igalia.com>
[WPE] Build error with ACCESSIBILITY=OFF after r288731
https://bugs.webkit.org/show_bug.cgi?id=235764
Reviewed by Adrian Perez de Castro.
* Source/cmake/OptionsWPE.cmake:
2022-01-27 Carlos Garcia Campos <cgarcia@igalia.com>
[WPE][a11y] Add option to build with ATSPI
https://bugs.webkit.org/show_bug.cgi?id=235701
Reviewed by Adrian Perez de Castro.
* Source/cmake/OptionsWPE.cmake:
2022-01-27 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Do not require GNU Gold usage to enable DEBUG_FISSION
https://bugs.webkit.org/show_bug.cgi?id=235737
Reviewed by Michael Catanzaro.
* Source/cmake/OptionsCommon.cmake: Allow enabling DEBUG_FISSION with any linker.
2022-01-27 Yusuke Suzuki <ysuzuki@apple.com>
Add .clangd similar to .ccls
https://bugs.webkit.org/show_bug.cgi?id=235743
Reviewed by Saam Barati.
This patch adds .clangd local configuration, which is similar to .ccls.
* .clangd: Added.
2022-01-26 Adrian Perez de Castro <aperez@igalia.com>
[CMake] Pass -pipe to compilers that support it
https://bugs.webkit.org/show_bug.cgi?id=235641
Reviewed by Darin Adler.
* Source/cmake/WebKitCompilerFlags.cmake: Add -pipe to compiler options where supported.
2022-01-25 Myles C. Maxfield <mmaxfield@apple.com>
Add another test for locale-specific shaping
https://bugs.webkit.org/show_bug.cgi?id=235558
Reviewed by Darin Adler.
Thanks so much to Just van Rossum for contributing the test font!!!
* metadata/contributors.json:
2022-01-20 Elliott Williams <emw@apple.com>
[XCBuild] Build via the workspace with USE_WORKSPACE=YES
https://bugs.webkit.org/show_bug.cgi?id=235385
rdar://87489695
Reviewed by Alexey Proskuryakov.
Experimental XCBuild support is available by passing USE_WORKSPACE=YES to Make. This is
roughly equivalent to opening WebKit.xcworkspace and building a scheme in the IDE.
A workspace build is only one `xcodebuild` invocation, in contrast with the traditional
recursive-Make build that iterates through each project directory. As a result, workspace
builds are faster: the build system can schedule targets from different projects to build
simultaneously, and there's lower xcodebuild overhead.
Workspaces build _schemes_, which are a collection of targets. By default, Make looks for a
scheme whose name matches the source directory (Source/WebCore => build scheme "WebCore").
Makefiles can customize this by setting SCHEME.
At this time, there is no guarantee of correctness when building with USE_WORKSPACE=YES, and
workspace builds are not checked by builders.
* Makefile: Use workspace logic when USE_WORKSPACE=YES
* Makefile.shared: xcodebuild invocation logic for workspace builds
* Source/Makefile: Use workspace logic and set custom SCHEME name
* WebKit.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings: Use XCBuild for workspace
builds
* WebKit.xcworkspace/xcshareddata/xcschemes/All Modules.xcscheme: Added, to correspond with
the top-level Makefile
* WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Let XCBuild determine build
order
* WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Let XCBuild determine build
order
2022-01-20 Don Olmstead <don.olmstead@sony.com>
[WinCairo] Make USE_CF conditional on ENABLE_WEBKIT_LEGACY
https://bugs.webkit.org/show_bug.cgi?id=235393
Reviewed by Fujii Hironori.
CoreFoundation is used heavily in WebKitLegacy on Windows and won't compile without it.
Modern WebKit doesn't have this requirement so tie CoreFoundation usage to whether
WebKitLegacy is being used.
* Source/cmake/OptionsWinCairo.cmake:
2022-01-19 Michael Catanzaro <mcatanzaro@gnome.org>
[WPE][GTK] ENABLE_JOURNALD_LOG has weird value
https://bugs.webkit.org/show_bug.cgi?id=235339
Reviewed by Philippe Normand.
Clean up the code that checks for journald.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
2022-01-18 Brandon Stewart <brandonstewart@apple.com>
Fix typos in Introduction.md
https://bugs.webkit.org/show_bug.cgi?id=235321
Reviewed by Michael Saboff.
Fix several typos in Introduction file.
* Introduction.md:
2022-01-17 Brandon Stewart <brandonstewart@apple.com>
Fix typo in README
https://bugs.webkit.org/show_bug.cgi?id=235309
Reviewed by Michael Saboff.
Fix typo in ReadMe. Updated 'embededded' to 'embedded'.
* ReadMe.md:
2022-01-17 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK][a11y] Stop using isolated tree for the ATSPI implementation
https://bugs.webkit.org/show_bug.cgi?id=235229
Reviewed by Adrian Perez de Castro.
Do not enable isolated tree for ATSPI.
* Source/cmake/OptionsGTK.cmake:
2022-01-14 Yusuke Suzuki <ysuzuki@apple.com> and Mikhail R. Gadelha <mikhail@igalia.com>
[JSC] Fix Linux 64bit compilation
https://bugs.webkit.org/show_bug.cgi?id=235232
Reviewed by Saam Barati.
* Source/cmake/OptionsCommon.cmake:
2022-01-13 Alejandro G. Castro <alex@igalia.com>
[GTK][WPE][WebGL2] compilation fixes
https://bugs.webkit.org/show_bug.cgi?id=225563
Reviewed by Chris Lord.
Fix the compilation and add the ANGLE dependency, the architecture
is still not the final one but it is handy to use WebGL2 demos for
testing already.
* Source/cmake/OptionsGTK.cmake: Added dependency with ANGLE.
* Source/cmake/OptionsWPE.cmake: Added dependency with
ANGLE. Remove the default ENABLE_WEBGL2 because it is the same
default value in WebKitFeatures.cmake.
2022-01-12 Chris Lord <clord@igalia.com>
[WPE] Fix building WebXR with ANGLE enabled
https://bugs.webkit.org/show_bug.cgi?id=235108
Reviewed by Alejandro G. Castro.
Remove conflict between WebXR and ANGLE WebGL for WPE.