Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas Refund on setVote() May Be Subject to Large Scale Manipulation #159

Closed
rossneilson opened this issue Jun 13, 2022 · 1 comment
Closed

Gas Refund on setVote() May Be Subject to Large Scale Manipulation #159

rossneilson opened this issue Jun 13, 2022 · 1 comment
Assignees
@dcrescimbeni
Labels
guilds severity: high
Milestone
v1.1.0

Comments

@rossneilson
Copy link
Collaborator

Screenshot 2022-06-13 at 12 29 30
@rossneilson rossneilson added this to the Guilds v1.0.0 milestone Jun 13, 2022
@rossneilson rossneilson moved this to Backlog in Sprints Jun 13, 2022
@AugustoL AugustoL modified the milestones: Guilds v1.0.0, v1.1.0 Jun 13, 2022
@AugustoL
Copy link
Member

We need to check that the gas spend in the transaction is higher to the amount of gas that it will be refunded.

@dcrescimbeni dcrescimbeni moved this from Backlog to In Progress in Sprints Jun 21, 2022
@dcrescimbeni dcrescimbeni mentioned this issue Jun 23, 2022
Merged
@dcrescimbeni dcrescimbeni moved this from In Progress to Review in Sprints Jun 23, 2022
@dcrescimbeni dcrescimbeni moved this from Review to Done in Sprints Jul 4, 2022
@AugustoL AugustoL closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcrescimbeni dcrescimbeni

Labels
guilds severity: high
Projects
Sprints
Status: Done
Milestone
v1.1.0
Development

No branches or pull requests
3 participants
@AugustoL @rossneilson @dcrescimbeni