[Feature] Compat for JEI

[no-name-provided]

Describe the bug
Only the four fluids register with only best (base) JEI installed. Items (guide book, crafter, paintbrush, chests, etc.), do not. Coupled with your mod's lack of documentation, this makes using it very difficult.

To Reproduce

Mod List

Mode LastWriteTime Length Name

---

-a---- 6/14/2024 5:09 PM 45440146 1.7.11-1.20.1.jar
-a---- 6/14/2024 11:26 PM 3636962 additionallanterns-1.1.1a-fabric-mc1.20.2.jar
-a---- 6/14/2024 11:52 PM 256944 alloy-forgery-2.1.2+1.20.jar
-a---- 6/18/2024 11:36 AM 1064362 appleskin-fabric-mc1.20.1-2.5.1.jar
-a---- 6/14/2024 5:09 PM 9852919 appliedenergistics2-fabric-15.2.0.jar
-a---- 6/14/2024 11:26 PM 585207 architectury-9.2.14-fabric.jar
-a---- 6/14/2024 11:26 PM 17975 AttributeFix-Fabric-1.20.1-21.0.4.jar
-a---- 6/14/2024 11:26 PM 189576 BarteringStation-v8.0.0-1.20.1-Fabric.jar
-a---- 6/14/2024 11:26 PM 253175 betterp2p-1.4.1-fabric.jar
-a---- 6/14/2024 5:09 PM 163340 BodiesBodies-1.0.1.jar
-a---- 6/14/2024 11:40 PM 322180 Bookshelf-Fabric-1.20.1-20.2.13.jar
-a---- 6/17/2024 2:36 AM 369647 BuildingWands-mc1.20.1-2.6.9-release.jar
-a---- 6/17/2024 2:47 AM 1159192 cloth-config-11.1.118-fabric.jar
-a---- 6/14/2024 5:09 PM 907790 compact-storage-1.20.1-fabric-6.0.1.64.jar
-a---- 6/18/2024 11:36 AM 591886 configured-fabric-1.20.1-2.2.3.jar
-a---- 6/14/2024 11:52 PM 938758 conjuring-1.0.29+1.20.jar
-a---- 6/17/2024 11:13 AM 122777 Controlling-fabric-1.20.1-12.0.2.jar
-a---- 6/14/2024 5:09 PM 53800 CutThrough-v8.0.2-1.20.1-Fabric.jar
-a---- 6/14/2024 11:26 PM 178298 DarkUtilities-Fabric-1.20.1-17.0.3.jar
-a---- 6/14/2024 11:26 PM 20716 durabilitytooltip-1.1.5-fabric-mc1.20.jar
-a---- 6/14/2024 6:07 PM 172663 Elemental_Alignment_1.1.5.jar
-a---- 6/15/2024 1:28 AM 1397622 embeddium-fabric-0.3.20+mc1.20.1.jar
-a---- 6/17/2024 2:45 AM 2107289 fabric-api-0.92.2+1.20.1.jar
-a---- 6/14/2024 11:40 PM 7015315 fabric-language-kotlin-1.11.0+kotlin.2.0.0.jar
-a---- 6/14/2024 5:09 PM 125197 ferritecore-6.0.1-fabric.jar
-a---- 6/14/2024 11:40 PM 397198 ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric.jar
-a---- 6/14/2024 11:26 PM 882142 ftb-chunks-fabric-2001.3.1.jar
-a---- 6/14/2024 11:26 PM 775783 ftb-library-fabric-2001.2.2.jar
-a---- 6/14/2024 11:26 PM 243962 ftb-teams-fabric-2001.3.0.jar
-a---- 6/14/2024 11:26 PM 130907 ftb-xmod-compat-fabric-2.1.1.jar
-a---- 6/17/2024 2:38 AM 215909 fusion-1.1.1-fabric-mc1.20.1.jar
-a---- 6/14/2024 5:09 PM 121984 globalxp-fabric-1.20.1-1.11.jar
-a---- 6/14/2024 11:26 PM 30635 Highlighter-1.20.1-fabric-1.1.9.jar
-a---- 6/14/2024 11:41 PM 123781 Iceberg-1.20.1-fabric-1.1.18.jar
-a---- 6/14/2024 5:09 PM 222894 InventorySorter-1.9.0-1.20.jar
-a---- 6/14/2024 5:09 PM 567066 Jade-1.20-fabric-11.9.2.jar
-a---- 6/14/2024 5:09 PM 1152396 jei-1.20.1-fabric-15.3.0.7.jar
-a---- 6/14/2024 11:26 PM 7208493 journeymap-1.20.1-5.9.23-fabric.jar
-a---- 6/17/2024 11:13 AM 46694 LeavesBeGone-v8.0.0-1.20.1-Fabric.jar
-a---- 6/17/2024 5:35 PM 60814 light-overlay-8.0.0.jar
-a---- 6/14/2024 6:07 PM 2404134 literally-chunk-loader-2.0.5.jar
-a---- 6/14/2024 5:09 PM 645865 lithium-fabric-mc1.20.1-0.11.2.jar
-a---- 6/14/2024 11:26 PM 438967 MapFrontiers-1.20.1-2.6.0p2-fabric.jar
-a---- 6/14/2024 11:26 PM 223689 merequester-fabric-1.20.1-1.1.4.jar
-a---- 6/17/2024 2:12 AM 7223151 Modern-Industrialization-1.8.5.jar
-a---- 6/17/2024 11:57 AM 720850 modmenu-7.2.1.jar
-a---- 6/17/2024 12:00 PM 983006 moretools-1.3.0+1.20.1.jar
-a---- 6/14/2024 5:09 PM 77943 MouseTweaks-fabric-mc1.20-2.26.jar
-a---- 6/14/2024 11:26 PM 754108 nemos-better-mending-1.1.1-1.20.1.jar
-a---- 6/15/2024 12:15 AM 8038 OpenSauceToastKiller.jar
-a---- 6/14/2024 6:07 PM 2543753 Origins-1.20.1-1.10.0.jar
-a---- 6/14/2024 11:54 PM 905421 owo-lib-0.11.2+1.20.jar
-a---- 6/14/2024 11:26 PM 856882 Patchouli-1.20.1-84-FABRIC.jar
-a---- 6/14/2024 11:40 PM 978720 PuzzlesLib-v8.1.20-1.20.1-Fabric.jar
-a---- 6/17/2024 2:36 AM 3577691 rechiseled-1.1.6-fabric-mc1.20.jar
-a---- 6/17/2024 2:25 AM 610971 redlogic-1.20.1-1.1.0.jar
-a---- 6/14/2024 11:40 PM 150486 revelationary-1.3.7+1.20.1.jar
-a---- 6/14/2024 5:09 PM 198940 scholar-1.20.1-1.0.0-forge.jar
-a---- 6/14/2024 5:09 PM 590818 scriptor-1.0.4-1.20.1-sgd-forge.jar
-a---- 6/17/2024 11:14 AM 80283 Searchables-fabric-1.20.1-1.0.3.jar
-a---- 6/17/2024 11:57 AM 861232 SimpleVeinminer-1.4.2.jar
-a---- 6/14/2024 6:07 PM 367467 specutils-1.0.1.jar
-a---- 6/14/2024 11:40 PM 207990 supermartijn642configlib-1.1.8a-fabric-mc1.20.jar
-a---- 6/14/2024 11:40 PM 564556 supermartijn642corelib-1.1.17-fabric-mc1.20.1.jar
-a---- 6/14/2024 5:09 PM 1258048 Surface-1.8.1-1.20.1.jar
-a---- 6/14/2024 11:40 PM 322358 TerraBlender-fabric-1.20.1-3.0.1.7.jar
-a---- 6/14/2024 6:07 PM 9582088 terrestria-6.0.13.jar
-a---- 6/19/2024 12:46 AM 102635 The Crop Reaping Mod-1.20.1-Fabric-2.2.jar
-a---- 6/14/2024 5:09 PM 238532 trinkets-3.7.2.jar
-a---- 6/14/2024 11:26 PM 1391845 YungsApi-1.20-Fabric-4.0.5.jar
-a---- 6/14/2024 11:26 PM 944170 YungsBetterDungeons-1.20-Fabric-4.0.4.jar
-a---- 6/14/2024 11:26 PM 517369 YungsBetterEndIsland-1.20-Fabric-2.0.6.jar
-a---- 6/14/2024 11:26 PM 947293 YungsBetterJungleTemples-1.20-Fabric-2.0.5.jar
-a---- 6/14/2024 11:26 PM 621495 YungsBetterMineshafts-1.20-Fabric-4.0.4.jar
-a---- 6/14/2024 11:26 PM 760974 YungsBetterNetherFortresses-1.20-Fabric-2.0.6.jar
-a---- 6/14/2024 11:26 PM 1165832 YungsBetterOceanMonuments-1.20-Fabric-3.0.4.jar
-a---- 6/14/2024 11:26 PM 611598 YungsBetterStrongholds-1.20-Fabric-4.0.3.jar
-a---- 6/14/2024 11:26 PM 307196 YungsBetterWitchHuts-1.20-Fabric-3.0.3.jar

Fabric Loader 0.15.11
IM 1.20.1
LWJGL 3 2.2.1

Expected behavior
I expected items/recipes to appear as I progressed through the mod, as described in the curseforge page:

"You may notice that most Items do not have a recipe displayed in tools like REI. Recipes and their matching Guidebook entries are unlocked step by step, giving you something new to toy with with each discovery."

Other mods have no problem registering recipes in a generic manner, and you don't list JEI (without add-ons) as specifically incompatible. I would expect JEI to work as-is, without bloat/clutter. I would also expect such an unusual incompatibility to be documented.

Minecraft version
1.20.1

Mod version
Tested with each of
spectrum 1.7.11 and spectrum 1.7.13
and both with or without
specutils 1.0.1 and embeddium 0.3.20+mc1.20.1

[DaFuqs]

Other mods have no problem registering recipes in a generic manner, and you don't list JEI (without add-ons) as specifically incompatible. I would expect JEI to work as-is, without bloat/clutter.

It is the other way around, actually! Each mod has to add dedicated compat with JEI for each single recipe type they add. This is nothing that happens automatically or generically.
Currently Spectrum supports REI & EMI as recipe viewers, since pretty much noone uses JEI on fabric. I agree adding support for JEI as recipe viewer would be nice, although this will take quite a bit of time to get done.

The missing items in JEI were caused by a bug in one of the libs, that Spectrum uses. That will be fixed via DaFuqs/Revelationary#20, thanks to @imreallybadatnames. That one will be fixed shortly.

[DaFuqs]

Oh yeah, to note: The version 1.3.8 of revelationary fixes the items not showing up in the item list.
That leaves adding recipe type support for JEI. But that one will be a huge chunk of work (how many people on fabric do even use it?)

[unilock]

It should be noted that EMI can also load JEI plugins when both EMI and JEI are installed alongside one another, so there's not really much of a point in having dedicated JEI integration when there's already EMI integration.

[no-name-provided]

I suppose I should address this:

1. How many people use JEI? I can't speak for the fabric community, but it's still popular among long term Minecraft players. I have the impression most of us prefer Forge. REI has some annoying antifeatures and EMI has a weirdly squished GUI, so I generally avoid 'em.

2. Version 1.3.8 of revolutionary fixes the problem. It makes a few more items show up, but there are no recipes and several items were still missing.

3. Supporting JEI is more work. EMI automatically grabs JEI recipes, and REI supports JEI plugins, so you're probably making more work or yourself by avoiding JEI. (Can't say for sure, because I haven't personally written dedicated plugins for these three mods.)

4. Nothing is automatic. Anything processed by vanilla recipes handlers (including crafting table recipes) should be added automatically. And JEI (normally) grabs its searchables directly from the creative tab, the block registry, and the item registry. If things aren't showing up, it's probably because you're doing something to break that automation.

Relevant links:
https://github.com/mezz/JustEnoughItems/wiki/Adding-and-Hiding-Items-%5B1.13-and-Up%5D
https://github.com/mezz/JustEnoughItems/wiki/Creating-Plugins-%5B1.13-and-Up%5D
https://github.com/mezz/JustEnoughItems/wiki/Recipes-Overview-%5B1.13-and-Up%5D
https://github.com/mezz/JustEnoughItems/blob/1.20.1/CommonApi/src/main/java/mezz/jei/api/IModPlugin.java

[Gronglegrowth]

JEI is not commonly used on Fabric, actually. In fact, of the three big recipe viewer mods, it is the newest to arrive on Fabric, and so support for it is far more limited generally - don't expect it.

Also, as for your third point of "making more work for yourself by avoiding JEI", I think that's just incorrect.

[no-name-provided]

Hi Gronglegrowth,

Spectrum explicitly advertises its support for forge, so the "not on my Fabric" stuff is a weird tact to take. And JEI is the oldest of the three recipe viewers, and generally well liked. I don't recall other Fabric mods having issues with JEI. The amount of hate it's getting here is strange.

Regarding your insight on my third point: Saying someone is "just incorrect" is unlikely to change their mind. If you want to share specific insight demonstrating a reasoned and educated perspective, that's one thing. But why comment just to say you disagree? Have you ever made a JEI plugin? Was it twice as hard as making an REI plugin? What does it require that REI doesn't?

[Gronglegrowth]

It was already said before that mods have to explicitly add compat for JEI; one cannot use an existing EMI or REI plugin. That is by definition more work than not implementing JEI support at all - which I feel is acceptable to do in this case, as it is more common for EMI or REI to be used considering it is primarily a Fabric mod. It'd be nice to have it, sure, but not necessary.

I've never touched REI plugins myself, but I have written some EMI support and at least looked at the existing JEI support for another mod I help make. The two are reasonably different, so I assume REI is also. Writing support for EMI definitely seems easier than JEI, to me at least.

[unilock]

@no-name-provided Given the lack of incentive for the majority of developers and players alike, it is unlikely any progress will be made on this front unless you submit a PR for JEI integration in Spectrum yourself. Feel free to do so.

[mrsterner]

I don't really care about JEI but if anyone want to add jei support there are some ways to hide recipes. Here are some examples present in both forge and fabric branch of the mod Malum

https://github.com/SammySemicolon/Malum-Mod/blob/157534dce57eddf18d6f863c079461c8968fd58f/src/main/java/com/sammy/malum/compability/jei/JEIHandler.java#L149

https://github.com/SammySemicolon/Malum-Mod/blob/1.6-1.20.1/src/main/java/com/sammy/malum/compability/jei/HiddenRecipeSet.java

[no-name-provided]

Thanks for clarifying, Gronglegrowth. I agree that there would be some transitioning overhead; it just seemed like maybe Dafuqs was overestimating the difficulty (and underestimating the convenience) of an all-in-one plugin. That, and I really think you're underestimating it's popularity. I agree that it may make more sense delay to looking into transitioning after EMI or REI introduce a breaking change, and the plugin needs to be revised anyway. And yes, I don't know if revelation is compatible with JEI, or the JEI functionality for hiding items (which I linked) is sufficient for Spectrum. Thank you for interpreting my report, suggestions, and questions in the friendly, cooperative spirit in which they were intended.

unilock: I was beginning to get that impression. Since I've been burned by Spectrum already, and and the lack of documentation makes identifying bugs painful, I'm probably just going to drop the mod (I kinda already did when the update to revelationary didn't fix the bugs). I only make addons/datapacks for mods I've already played, and found enjoyable.

Azzyypaaras: You have been reported for bullying/harassment. You seem to have misunderstood the points I was making and/or asking about. You have revealed a significant gap in your understanding of the mods being discussed. You inserted random, irrelevant information. And you made unfair, negative assumptions. We clearly can't have a polite interaction, so I'll ask you to stop interacting with me.

Dafuqs: If you have no current plans to add JEI compatibility, and you're happy with items that show up in the EMI search not showing up in the JEI search, then you may want to close this ticket. I will be unsubscribing shortly.

Obligatory disclaimer: suggestions aren't demands. Dafuqs doesn't need to justify supporting/not supporting mods. When they do choose to discuss their reasons, additional comments are intended to be informative (for either of us), not argumentative.