Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geometry leaks in daemon #950

Closed
ghost opened this issue Nov 1, 2023 · 5 comments
Closed

geometry leaks in daemon #950

ghost opened this issue Nov 1, 2023 · 5 comments
Labels

Comments

@ghost
Copy link

ghost commented Nov 1, 2023

Usstremor and tremor-2016 both have a geometry leak.

Apparently, tremor-2016 does not have this leak in unvanquished, and I believe that kind of problem can not be related to gamelogic.

@slipher
Copy link
Member

slipher commented Nov 2, 2023

I thought a geometry leak means that the brushes in a BSP do not fully enclose the inside of the map - that there is a path from the playable area of the map to the void outside that avoids brushes. Is that what you're talking about here?

@ghost
Copy link
Author

ghost commented Nov 2, 2023

From a player point of a view, a geometry leak is when you can go out of the geometry. A player, or a gamelogic developper, is not necessarily able to understand if the leak comes from the bsp or from how the collisions are managed.
I do not know enough about what the BSP is or how the math are done to be able to say if it comes from the data or the code interpreting it, but the fact a leak exists in unvanquished but not in tremulous, with the same data, to me, seems to indicate a collision bug.
I know a bit the code of some collision handling in unvanquished, and I would be quite curious to see someone able to say with certainty if that stuff is buggy or not, so I think the best to do is to check with tremulous.
Of course, it might be that the dretch size changed between the games: in unv, it have a width of 30, and I could not find this info easily in the trem's code I use for reference, perhaps it was larger, but that would mean larger than a human, as well, so it would surprise me.

@VReaperV
Copy link
Contributor

This is likely the same bug is in rotcannon-garbage where you can fall through the tubes at the sides of the main area (e. g. in front of viewpos -456 -1024 -1365 173).

@VReaperV
Copy link
Contributor

VReaperV commented Sep 2, 2024

The bug on usstremor has been fixed apparently by updating the map itself, but it still remains on other maps.

@VReaperV
Copy link
Contributor

Duplicate of #1307.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants