Skip to content

Commit 7bc99fb

Browse files
committed
fix(gulp:test): fix gulp test dependencies
update `test:client` dependencies and ensure correct async run hints
1 parent fcad9c1 commit 7bc99fb

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

app/templates/gulpfile.babel(gulp).js

+4-4
Original file line numberDiff line numberDiff line change
@@ -407,7 +407,7 @@ gulp.task('serve:dist', cb => {
407407
cb);
408408
});
409409

410-
gulp.task('test', ['wiredep:test'], cb => {
410+
gulp.task('test', cb => {
411411
return runSequence('test:server', 'test:client', cb);
412412
});
413413

@@ -431,7 +431,7 @@ gulp.task('mocha:integration', () => {
431431
.pipe(mocha());
432432
});
433433

434-
gulp.task('test:client', ['wiredep:test'<% if(filters.ts) { %>, 'tsd:test', 'transpile:client', 'transpile:client:test'<% } %>], (done) => {
434+
gulp.task('test:client', ['wiredep:test', 'constant'<% if(filters.ts) { %>, 'tsd:test', 'transpile:client', 'transpile:client:test'<% } %>], (done) => {
435435
new KarmaServer({
436436
configFile: `${__dirname}/${paths.karma}`,
437437
singleRun: true
@@ -456,7 +456,7 @@ gulp.task('wiredep:client', () => {
456456
});
457457

458458
gulp.task('wiredep:test', () => {
459-
gulp.src(paths.karma)
459+
return gulp.src(paths.karma)
460460
.pipe(wiredep({
461461
exclude: [
462462
/bootstrap-sass-official/,
@@ -545,7 +545,7 @@ gulp.task('jade', function() {
545545

546546
gulp.task('constant', function() {
547547
let sharedConfig = require(`./${serverPath}/config/environment/shared`);
548-
plugins.ngConstant({
548+
return plugins.ngConstant({
549549
name: '<%= scriptAppName %>.constants',
550550
deps: [],
551551
wrap: true,

0 commit comments

Comments
 (0)