-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spin.js breaks whole build process #522
Comments
I think #420 is related, give that a shot? |
@9mm in your grunt file, does the usemin: {
...
js: ['<%= yeoman.dist %>/public/{,*/}*.js'],
...
} same with rev: {
dist: {
files: {
src: [
'<%= yeoman.dist %>/public/{,*/}*.js',
...
]
}
}
} If so, I'm wondering if changing them to: '<%= yeoman.dist %>/public/**/*.js' might help? |
Still doesn't fix. I had to change them to this and break them out separately: //'<%= yeoman.dist %>/public/{,*/}*.js', // original line (spin.js breaks)
'<%= yeoman.dist %>/public/app/{,*/}*.js', // replacement
'<%= yeoman.dist %>/public/assets/{,*/}*.js', // replacement |
This seems like it could be a common issue if Bower allows package names to contain file extensions. Using |
using |
I've got the same issue with animate.css. I solved it by excluding directories with rev: {
dist: {
files: {
src: [
'<%= yeoman.dist %>/public/{,*/}*.js',
'<%= yeoman.dist %>/public/{,*/}*.css',
'<%= yeoman.dist %>/public/assets/images/{,*/}*.{png,jpg,jpeg,gif,webp,svg}',
'<%= yeoman.dist %>/public/assets/fonts/*',
'!<%= yeoman.dist %>/public/bower_components/*.{css,js}'
]
}
}
} |
I had a similar issue, stefbach pointed out that this issue was resolved in v3 of usemin. I did not try it, but this could be a great improvement! |
If you do not want to exclude the whole bower_components directory, you can exclude the affected library's folder and include the libraries .js files again. Here an example for 'auth0.js':
|
So this person decided to name their bower package with a file extension... really kind of stupid I think.
What is the easiest way to fix all this? The original problem was with rev, i tried a hacky fix and now the problem is with usemin:js.
Is there a way to rename a folder with bower or something, or an easier way I'm not thinking of? Thanks!
The text was updated successfully, but these errors were encountered: