Skip to content

Commit 535930e

Browse files
committed
Refactor: apply code review feedback
1 parent 5b4f429 commit 535930e

File tree

2 files changed

+4
-26
lines changed

2 files changed

+4
-26
lines changed

kth-smallest-element-in-a-bst/HC-kang.ts

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ function kthSmallest(root: TreeNode | null, k: number): number {
5050
}
5151

5252
/**
53+
* NOT MY SOLUTION - NO NEED TO REVIEW
5354
* Awesome solution from leetcode
5455
*/
5556
function kthSmallest(root: TreeNode | null, k: number): number {
@@ -58,29 +59,6 @@ function kthSmallest(root: TreeNode | null, k: number): number {
5859
assess. smallest value can be 0. At least k nodes, which can be at its smallest, 1.
5960
approach. DFS with backtracking. Traverse down the left edges until we hit null. if k is 1, return that value. Else, backtrack, go right, then try to go left again. Use a stack.
6061
*/
61-
62-
// let currentRank = 0;
63-
64-
// let stack = [];
65-
66-
// let currentNode = root;
67-
68-
// while (currentNode || stack.length > 0) {
69-
// while (currentNode) {
70-
// stack.push(currentNode);
71-
72-
// currentNode = currentNode.left;
73-
// }
74-
75-
// currentNode = stack.pop();
76-
77-
// currentRank++;
78-
79-
// if (currentRank === k) return currentNode.val;
80-
81-
// currentNode = currentNode.right;
82-
// }
83-
8462
const stack = [];
8563

8664
let currentRank = 0;

top-k-frequent-elements/HC-kang.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ Output: [1]
1313
// Time complexity: O(nlogn)
1414
// Space complexity: O(n)
1515
function topKFrequent(nums: number[], k: number): number[] {
16-
const acc = new Map<number, number>();
16+
const frequentMap = new Map<number, number>();
1717
for (const num of nums) { // s.c. O(n)
18-
acc.set(num, (acc.get(num) || 0) + 1);
18+
frequentMap.set(num, (frequentMap.get(num) || 0) + 1);
1919
}
20-
return Array.from(acc.entries())
20+
return Array.from(frequentMap.entries())
2121
.sort((a, b) => b[1] - a[1]) // this will cost t.c. O(nlogn)
2222
.slice(0, k)
2323
.map((v) => v[0]);

0 commit comments

Comments
 (0)