Skip to content

Commit d907097

Browse files
committed
- 리뷰 반영
1 parent 37fa2b2 commit d907097

File tree

4 files changed

+6
-80
lines changed

4 files changed

+6
-80
lines changed

contains-duplicate/Geegong.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ public class Geegong {
99
* time complexity : O(n)
1010
* space complexity : o(n)
1111
* @param nums
12-
* @return
12+
* @return boolean
1313
*/
1414
public boolean containsDuplicate(int[] nums) {
1515

longest-consecutive-sequence/Geegong.java

Lines changed: 1 addition & 54 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class Geegong {
1515
* - O (N) : sorting된걸 한번 더 순회
1616
* Space complexity : O(N) -> hash set
1717
* @param nums
18-
* @return
18+
* @return int
1919
*/
2020
public int longestConsecutive(int[] nums) {
2121
if (nums.length == 0) {
@@ -46,61 +46,8 @@ public int longestConsecutive(int[] nums) {
4646
prev = sortedNums[index];
4747
}
4848

49-
50-
5149
return Math.max(currentLength, maxLength);
52-
53-
54-
55-
56-
57-
58-
59-
60-
61-
62-
63-
64-
65-
66-
6750
}
68-
// HashSet<Integer> setOfNums = new HashSet<>();
69-
// // key : startIndex , value : length
70-
// Map<Integer, Integer> lengthMap = new HashMap<>();
71-
//
72-
// // sort..? 를 해야될까 싶음..
73-
//
74-
// // initialize
75-
// for (int num : nums) {
76-
// setOfNums.add(num);
77-
// }
78-
//
79-
// Integer longest = 0;
80-
//
81-
// for (Integer num : setOfNums) {
82-
// int length = iterate(setOfNums, num, 0, lengthMap);
83-
// longest = Math.max(longest, length);
84-
// }
85-
//
86-
// return longest;
87-
// }
88-
//
89-
// public Integer iterate(HashSet<Integer> hashSet, int currIndex, int currLength, Map<Integer, Integer> lengthMap) {
90-
// if (lengthMap.containsKey(currIndex)) {
91-
// return lengthMap.get(currIndex);
92-
// }
93-
//
94-
// if (hashSet.contains(currIndex)) {
95-
// currLength++;
96-
// return iterate(hashSet, currIndex+1, currLength, lengthMap);
97-
//
98-
// } else {
99-
// lengthMap.put(currIndex, currLength);
100-
// return currLength;
101-
// }
102-
//
103-
// }
10451

10552
}
10653

top-k-frequent-elements/Geegong.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public class Geegong {
1515
* - O(N) : frequency 그룹핑된 그룹 갯수만큼 iterate
1616
* @param nums
1717
* @param k
18-
* @return
18+
* @return int[]
1919
*/
2020
public int[] topKFrequent(int[] nums, int k) {
2121

@@ -56,7 +56,8 @@ public int[] topKFrequent(int[] nums, int k) {
5656

5757
return result.stream().mapToInt(Integer::intValue).toArray();
5858

59-
59+
// 아래 문제풀이는 예전 기수에 풀었던 방법으로 Map 으로 빈도수와 num을 관리하는 값을 가지긴 하나
60+
// sorting은 하지 않고 maxNumOfFrequency를 구하여 순차적으로 작은 값들을 꺼내서 k만큼 리턴한다
6061
// int[] result = new int[k];
6162
//
6263
// // key : num element in nums / value : frequency of num elements

two-sum/Geegong.java

Lines changed: 1 addition & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ public class Geegong {
88
* space complexity : O(n)
99
* @param nums
1010
* @param target
11-
* @return
11+
* @return int[]
1212
*/
1313
public int[] twoSum(int[] nums, int target) {
1414
int[] result = new int[2];
@@ -27,28 +27,6 @@ public int[] twoSum(int[] nums, int target) {
2727
}
2828

2929
return result;
30-
31-
32-
// Map<Integer, Integer> map = new HashMap<>();
33-
// int[] result = new int[2];
34-
//
35-
// // if target = -9 / num = 1 , num = -10
36-
// for (int index=0; index<nums.length; index++) {
37-
// map.put(nums[index], index);
38-
// }
39-
//
40-
// for (int index=0; index<nums.length; index++) {
41-
// int difference = target - nums[index];
42-
//
43-
// if (map.containsKey(difference)
44-
// && map.get(difference) != index) {
45-
// result[0] = index;
46-
// result[1] = map.get(difference);
47-
// return result;
48-
// }
49-
// }
50-
//
51-
// return result;
5230
}
5331
}
5432

0 commit comments

Comments
 (0)