Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android Edge Chromium no longer detected #151

Closed
GaryHyland opened this issue Oct 8, 2020 · 2 comments · Fixed by #152
Closed

Android Edge Chromium no longer detected #151

GaryHyland opened this issue Oct 8, 2020 · 2 comments · Fixed by #152

Comments

@GaryHyland
Copy link

The User Agent for this is now
Mozilla/5.0 (Linux; Android 9; SM-N950F) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/77.0.3865.116 Mobile Safari/537.36 EdgA/45.08.4.5074
This no longer matches the test. This is quite a popular browser, so would be good to recognise, pretty easy change to the test also.
@DamonOehlman
Copy link
Owner

@GaryHyland thanks for the report - I'll add a breaking test for that user agent and then fixup the regex to ensure the package provides useful output.

@DamonOehlman DamonOehlman mentioned this issue Oct 8, 2020
Merged
@DamonOehlman
Copy link
Owner

Published as 5.2.0

@kalbroni7 kalbroni7 mentioned this issue Jun 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implement edge chromium detection support for android DamonOehlman/detect-browser
2 participants
@DamonOehlman @GaryHyland