Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings.baseUrl in AspNet5 is an empty string #49

Closed
mrahhal opened this issue Dec 14, 2015 · 1 comment
Closed

settings.baseUrl in AspNet5 is an empty string #49

mrahhal opened this issue Dec 14, 2015 · 1 comment
Labels
bug

Comments

@mrahhal
Copy link
Contributor

mrahhal commented Dec 14, 2015

In AspNet5, the base path is "" where it should have been "/". This is not the same with mvc5 because the base url value is always "/" at runtime.
We should check for an empty string and use "/" instead when that happens to compensate for AspNet5.
@mrahhal mrahhal mentioned this issue Dec 14, 2015
Merged
@Daniel15
Copy link
Owner

Thanks for your fix! :D

@Daniel15 Daniel15 added the bug label Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Daniel15 @mrahhal