-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mermaid block code configuration based. #7
Comments
Yeah, I can try this out! Sorry I took so long to respond. I'll have a stab at it this week |
So I've got this working on my local machine and it seems good. I want to make sure I understand how things are meant to work, though, and I have a question: These lines you've added to $blockBegin = str_replace("[","\\[",$blockBegin);
$blockBegin = str_replace("]","\\]",$blockBegin);
$blockEnd = str_replace("[","\\[",$blockEnd);
$blockEnd = str_replace("]","\\]",$blockEnd);
$blockEnd = str_replace("/","\\/",$blockEnd); ...were added so that, if someone sets the If I'm right about that, then I'll proceed. I am going to set the default value of the delimiters to Two last questions. First, would you prefer that I create a development branch on the repository where you can make a pull request? That way your work will be attributed to your GitHub account and stuff. If so, please write commit messages following this guide. Second, how would you like to be credited in the release notes? Thanks for your help! |
It´s correct. The |
Hi.
This is a new feature for your consideration
Gitlab or Stackedit uses the syntax for mermaid code block recognition.
```mermaid
mermaid code
```
Maybe you could add a new feature to set the block delimiters.
It could be something like that.
In mermaid-diagrams.yaml#L6 (General Settings) I add two new properties
In mermaid-diagrams.php#L40
I replace
by
And finaliy, the code in the method parseInjectMermaid, could look something like this
Thanks for your attention and regards.
The text was updated successfully, but these errors were encountered: