Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use newer angular framework version #754

Merged
merged 33 commits into from
Jul 4, 2024
Merged

Conversation

DanielHabenicht
Copy link
Owner

@DanielHabenicht DanielHabenicht commented Jul 2, 2024

Update angular framework

BREAKING CHANGE:

Might not be compatible with previous angular versions

Copy link

github-actions bot commented Jul 2, 2024

We are following the Conventional Commit Format. Please make sure that your Pull Request title and body conform to this format, otherwise, it might not be released. Here is a short example:

fix(webapp): correct styling in cool component
<type>[optional scope]: <description>

These are the most used types: (you can find more here)

Type Meaning Resulting Semantic Release
fix patches a bug PATCH (v1.0.0 -> v1.0.1)
feat introduces a new feature MINOR (v1.0.0 -> v1.1.0)
chore other non releasing code changes NONE (v1.0.0 -> v1.0.0

In the Pull Request Body please describe what changes for the user of the application. If the user has to do things differently than before (excluding new functionality) please include BREAKING CHANGE at the end. This will trigger a major release (v1.0.0 -> v2.0.0)

Copy link

github-actions bot commented Jul 2, 2024

We are following the Conventional Commit Format. Please make sure that your Pull Request title and body conform to this format, otherwise, it might not be released. Here is a short example:

fix(webapp): correct styling in cool component
<type>[optional scope]: <description>

These are the most used types: (you can find more here)

Type Meaning Resulting Semantic Release
fix patches a bug PATCH (v1.0.0 -> v1.0.1)
feat introduces a new feature MINOR (v1.0.0 -> v1.1.0)
chore other non releasing code changes NONE (v1.0.0 -> v1.0.0

In the Pull Request Body please describe what changes for the user of the application. If the user has to do things differently than before (excluding new functionality) please include BREAKING CHANGE at the end. This will trigger a major release (v1.0.0 -> v2.0.0)

1 similar comment
Copy link

github-actions bot commented Jul 2, 2024

We are following the Conventional Commit Format. Please make sure that your Pull Request title and body conform to this format, otherwise, it might not be released. Here is a short example:

fix(webapp): correct styling in cool component
<type>[optional scope]: <description>

These are the most used types: (you can find more here)

Type Meaning Resulting Semantic Release
fix patches a bug PATCH (v1.0.0 -> v1.0.1)
feat introduces a new feature MINOR (v1.0.0 -> v1.1.0)
chore other non releasing code changes NONE (v1.0.0 -> v1.0.0

In the Pull Request Body please describe what changes for the user of the application. If the user has to do things differently than before (excluding new functionality) please include BREAKING CHANGE at the end. This will trigger a major release (v1.0.0 -> v2.0.0)

Copy link

github-actions bot commented Jul 2, 2024

We are following the Conventional Commit Format. Please make sure that your Pull Request title and body conform to this format, otherwise, it might not be released. Here is a short example:

fix(webapp): correct styling in cool component
<type>[optional scope]: <description>

These are the most used types: (you can find more here)

Type Meaning Resulting Semantic Release
fix patches a bug PATCH (v1.0.0 -> v1.0.1)
feat introduces a new feature MINOR (v1.0.0 -> v1.1.0)
chore other non releasing code changes NONE (v1.0.0 -> v1.0.0

In the Pull Request Body please describe what changes for the user of the application. If the user has to do things differently than before (excluding new functionality) please include BREAKING CHANGE at the end. This will trigger a major release (v1.0.0 -> v2.0.0)

@DanielHabenicht DanielHabenicht changed the title General update feat: use newer angular framework version Jul 2, 2024
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 45.90%. Comparing base (6379e7f) to head (578d9d7).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
projects/ngx-vcard/src/lib/ngx-vcard.formatter.ts 27.27% 16 Missing ⚠️
...ib/types/parameter/BasicPropertyParameters.type.ts 66.66% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (6379e7f) and HEAD (578d9d7). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6379e7f) HEAD (578d9d7)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
- Coverage   55.72%   45.90%   -9.83%     
==========================================
  Files           7        5       -2     
  Lines         192      183       -9     
  Branches       69       66       -3     
==========================================
- Hits          107       84      -23     
- Misses         56       94      +38     
+ Partials       29        5      -24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

projects/ngx-vcard/src/lib/helpers.ts Fixed Show fixed Hide fixed
projects/ngx-vcard/src/lib/helpers.ts Fixed Show fixed Hide fixed
projects/ngx-vcard/src/lib/helpers.ts Fixed Show fixed Hide fixed
DanielHabenicht and others added 2 commits July 2, 2024 22:24
Co-authored-by: Restyled.io <commits@restyled.io>
// character (U+002C). Therefore, a COMMA character in a value MUST be
// escaped with a BACKSLASH character (U+005C), even for properties that
// don't allow multiple instances (for consistency).
.replace(/,/g, ',')

Check warning

Code scanning / CodeQL

Replacement of a substring with itself Medium

This replaces ',' with itself.
// escaped. On input, an escaped SEMICOLON character is never a field
// separator. An unescaped SEMICOLON character may be a field
// separator, depending on the property in which it appears.
.replace(/;/g, ';')

Check warning

Code scanning / CodeQL

Replacement of a substring with itself Medium

This replaces ';' with itself.
@DanielHabenicht DanielHabenicht changed the title feat: use newer angular framework version feat!: use newer angular framework version Jul 3, 2024
@DanielHabenicht DanielHabenicht merged commit 9af7f13 into master Jul 4, 2024
10 of 12 checks passed
Copy link

github-actions bot commented Jul 4, 2024

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@DanielHabenicht DanielHabenicht deleted the general-update branch November 30, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant