Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring proposal #14

Open
oslego opened this issue Sep 22, 2015 · 1 comment
Open

Refactoring proposal #14

oslego opened this issue Sep 22, 2015 · 1 comment

Comments

@oslego
Copy link

oslego commented Sep 22, 2015

Hi Daniel,

Thank you for building doppler!

It's one of the projects that have inspired me to go speak at a conference about unconventional ways to transmit data and input. I will use doppler on stage, of course giving due credit to you and the paper authors.

I made some updates to a fork of the project, mainly to suit my needs during an interactive demo on stage. The changes introduce the ability to turn doppler on/off, update API references and expose callbacks. I'd like to contribute my changes back to the main project, but I batched them together in one "refactoring" branch rather than multiple atomic commits.

Please have a look at the diff and the comments at the end.

Are you open to accepting this batch of changes as a pull request?

They do introduce breaking changes for existing demos, but I'm willing to help update them (I replaced init(callback) with start() and on('sample', callback)).

@SMUsamaShah
Copy link

@SidBlack this isn't your project.

Repository owner deleted a comment Apr 23, 2022
Repository owner deleted a comment Apr 23, 2022
Repository owner deleted a comment Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants