-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why the forked branch of vue #1
Comments
I found vuejs/vue-loader#109 (comment) and saw above it where you asked questions to get your frozen branch functional. Seems like https://github.com/vuejs-templates needs an official setup for Typescript with https://vuejs.org/v2/guide/single-file-components.html . Feels like we are shooting at a moving target. I never was any good at DuckHunt 🦆 . 😃 |
I'm also trying to closely follow the progress on this, is there an open PR where we can track to see when your changes get merged into vue? |
Daniel, |
Hey guys, the PR is up at vuejs/vue#5887 |
@DanielRosenwasser thank you for the update! All the labor and tricky decisions that went into this PR you've done is huge, so thanks! For those who stumble upon this, it looks like VueJS 2.5 might be the most likely future version which will get more canonical type usage. The real limiters on this getting into the VueJS 2.4 or 2.5 are these:
|
The latest merge request is getting code reviewed at vuejs/vue#6391 |
@DanielRosenwasser and @HerringtonDarkholme looks like through blood, sweat and tears you guys got this thing working in first rate order!
Looks like https://vuejs.org/v2/guide/typescript.html covers the new approach well! Thank you, thank you, as even Evan You thanks you! :) Seriously, I'm very pumped up by this! |
You're welcome! Super glad to see the enthusiasm. Keep me posted on how using it works out! |
I plan to try it out on a clean new project once their is a Typescript Template for the Vue CLI . And I'll let you know. My last big project I used Typescript and AngularJS (ng1.x) and I really liked what Typescript added. Now with computed-properties like I used to use back in Ember 🐹, and single-file-components I feel unstoppable 🔁 ! |
Hi Daniel,
This and the starter setup at https://github.com/Microsoft/TypeScript-Vue-Starter are really cool. Thanks for putting the time in to these to make them clear and easy for newbies!
So the question I have is why must we use your branch, at a specific commit of VueJS? Are these features that play nice with typescript coming to the master branch? Having built a production single page app in ember that was dependent on a side branch like this, I know it can be done, but when you need or want a new feature you have to play this weird self-patching game that's kind of a drag. So I just wanted the scoop from you about why this is setup this way before I invest too deeply.
The text was updated successfully, but these errors were encountered: