Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent Count range check break secplus_v2 keys #370

Closed
AndrewPGA opened this issue Feb 28, 2023 · 1 comment
Closed

Recent Count range check break secplus_v2 keys #370

AndrewPGA opened this issue Feb 28, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@AndrewPGA
Copy link

Describe the bug.

if((instance->generic.cnt + furi_hal_subghz_get_rolling_counter_mult()) >= 0xFFFF) {

Commit 172c0e0 set the upper key range to 0xFFFF, which might break current keys. Rolling code for secplus_v2 is 28 bits, therefore the max value should be 0xFFFFFFF (2^28).
Tested on a chamberlain garage door opener, after enroll a key w/ rolling code 0xFFFE, the opener accepted the key once (0xFFFF), and does not accept the next one (0x0)

Reproduction

enroll a key w/ rolling code 0xFFFE on a chamberlain garage door opener , the opener accepted the key once (0xFFFF), and does not accept the next one (0x0) and after

Target

No response

Logs

No response

Anything else?

Did not test other protocols that made the same change in that commit.

@AndrewPGA AndrewPGA added the bug Something isn't working label Feb 28, 2023
@xMasterX xMasterX self-assigned this Feb 28, 2023
@xMasterX
Copy link
Member

Fixed, thanks for report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants