Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V540TND keyboad illumination changes on coldboot #1055

Closed
philipandag opened this issue Sep 16, 2024 · 3 comments
Closed

V540TND keyboad illumination changes on coldboot #1055

philipandag opened this issue Sep 16, 2024 · 3 comments
Labels
bug Something isn't working EC firmware needs review novacustom_v54_mtl NovaCustom V54 Series

Comments

@philipandag
Copy link

Component

Dasharo firmware, EC firmware

Device

NovaCustom V54 14th Gen

Dasharo version

v0.9.1-rc5

Dasharo Tools Suite version

--

Test case ID

ECR25

Brief summary

The keyboard backlight setting changes after a coldboot

How reproducible

100% in 2 tries on Ubuntu and 2 tries on Windows

How to reproduce

Boot an OS, change backlight setting (alternating turned off and full brightness is the easiest to notice), disconnect all external power supplies and disconnect the battery. Connect the battery back, boot into an OS

Expected behavior

The backlight setting from before the coldboot should remain

Actual behavior

The backlight setting changes. In all tests the default was off and I have changed it to the max brightness. After coldboot it's always back to being off.

Screenshots

cbmem logs from Ubuntu, for -2 (boot before coldboot) and -1 (the coldboot)
cbmem-keyboard-backlight-1.log
cbmem-keyboard-backlight-2.log

Additional context

No response

Solutions you've tried

No response

@philipandag philipandag added bug Something isn't working needs review labels Sep 16, 2024
@mkopec
Copy link
Member

mkopec commented Sep 17, 2024

No need to disconnect the battery to perform a coldboot. Just shut down, unplug wall adapter and wait a second.

The EC saves settings upon (graceful) shutdown, so you have to go through the proper shutdown, instead of hot-removing AC and battery completely

@philipandag
Copy link
Author

Does it mean that the AC needs to be plugged in for a warmboot and without it the os shutdown results in a coldboot? In that case the Dasharo test specification needs updates because it says to remove the battery.
https://docs.dasharo.com/unified-test-documentation/dasharo-compatibility/31G-ec-and-superio/#ecr025001-permanent-keyboard-illumination-after-cold-boot-firmware

@mkopec
Copy link
Member

mkopec commented Oct 2, 2024

Power states explained in https://docs.dasharo.com/transparent-validation/ec-information/ec-explained/ , closing

@mkopec mkopec closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EC firmware needs review novacustom_v54_mtl NovaCustom V54 Series
Projects
None yet
Development

No branches or pull requests

2 participants