Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keywords.Power On not overridden by definitions from common platform configs #703

Open
philipanda opened this issue Feb 25, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@philipanda
Copy link
Contributor

Device

All devices defining Power On in their common configs: Protectli, Novacustom

RTE version

OSFV version

develop

Affected component(s) or functionality

All the tests on Protectli and Novacustom platforms will fail now because of ambiguous definition of Pwoer On

Brief summary

Power On Ambiguous after adding it in keywords.robot

How reproducible

100%

How to reproduce

Run any test suite using Power On on a platform that defines it in a common config, like protectli-common or novacustom-common

Expected behavior

The definition from the platform configs should be overriding the one in keywords.robot

Actual behavior

Both definitions are equal and the keyword is ambiguous

Link to screenshots or logs

Example log: display-ports-and-lcd-support.robot_log.zip

Additional context

Because of adding Power On to keywords.robot here, in order to document it only in one place instead of on every it's implementation, the Power On keyword is ambiguous if defined in common platform configs. The ability to override it in a platform configs is added thanks to this change.

Solutions you've tried

A really quick but maybe somewhat dirty fix is to add something like:

Power On
    protectli-common.Power On

To all the platform configs to explicitly override the keyword.

Maybe a better solution would be to define a list of common config files, so that they can be added to the library order call (this change).

Or maybe it would be better to just remove the keyword from keywords.robot and duplicate the documentation for every implementation?

@philipanda philipanda added the bug Something isn't working label Feb 25, 2025
@mkopec
Copy link
Member

mkopec commented Feb 28, 2025

Kwd removed in d5de9ae

Would be nice to have a default kwd that reminds us to add a platform specific kwd but if it doesn't work, hopefully people can figure it out without it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants