You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Because of adding Power On to keywords.robothere, in order to document it only in one place instead of on every it's implementation, the Power On keyword is ambiguous if defined in common platform configs. The ability to override it in a platform configs is added thanks to this change.
Solutions you've tried
A really quick but maybe somewhat dirty fix is to add something like:
Power On
protectli-common.Power On
To all the platform configs to explicitly override the keyword.
Maybe a better solution would be to define a list of common config files, so that they can be added to the library order call (this change).
Or maybe it would be better to just remove the keyword from keywords.robot and duplicate the documentation for every implementation?
The text was updated successfully, but these errors were encountered:
Would be nice to have a default kwd that reminds us to add a platform specific kwd but if it doesn't work, hopefully people can figure it out without it :)
Device
All devices defining Power On in their common configs: Protectli, Novacustom
RTE version
OSFV version
develop
Affected component(s) or functionality
All the tests on Protectli and Novacustom platforms will fail now because of ambiguous definition of Pwoer On
Brief summary
Power On Ambiguous after adding it in
keywords.robot
How reproducible
100%
How to reproduce
Run any test suite using Power On on a platform that defines it in a common config, like protectli-common or novacustom-common
Expected behavior
The definition from the platform configs should be overriding the one in keywords.robot
Actual behavior
Both definitions are equal and the keyword is ambiguous
Link to screenshots or logs
Example log: display-ports-and-lcd-support.robot_log.zip
Additional context
Because of adding
Power On
tokeywords.robot
here, in order to document it only in one place instead of on every it's implementation, thePower On
keyword is ambiguous if defined in common platform configs. The ability to override it in a platform configs is added thanks to this change.Solutions you've tried
A really quick but maybe somewhat dirty fix is to add something like:
To all the platform configs to explicitly override the keyword.
Maybe a better solution would be to define a list of common config files, so that they can be added to the library order call (this change).
Or maybe it would be better to just remove the keyword from keywords.robot and duplicate the documentation for every implementation?
The text was updated successfully, but these errors were encountered: