Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enh] All blocks: possibility to use of icons/images for all blocks #26

Closed
HansieNL opened this issue Aug 19, 2019 · 9 comments
Closed
Assignees
Labels
enhancement New feature or request

Comments

@HansieNL
Copy link
Collaborator

Now there a blocks where adding an image is not possible, because of it's fixed code.
For example: publictransport.ovinfotrains= { image: 'ns.png', station:... The image will not be shown.

@HansieNL HansieNL added the enhancement New feature or request label Aug 19, 2019
@aalwash
Copy link
Contributor

aalwash commented Aug 19, 2019

Isn't this the same issues as #14 ?

@lokonli lokonli self-assigned this Aug 19, 2019
@lokonli
Copy link
Collaborator

lokonli commented Aug 19, 2019

I've fixed and closed it for blocktitles, see #14.
I'll use the fix as a template for the other blocks as well.

streamplayer
publictransport

more?

@HansieNL
Copy link
Collaborator Author

I'll try to complete my list...

  • traffic
  • train
  • news
  • gas
  • energy
  • thermostat setpoint

@lokonli
Copy link
Collaborator

lokonli commented Aug 22, 2019

streamplayer
publictransport
traffic
train
news
gas
energy
thermostat setpoint
longfonds

This is becoming too much to make a fix 10 times. I'm going to switch to a class based block template architecture. Quite a change, so implementation will take more time.

@HansieNL
Copy link
Collaborator Author

Take your time. To keep it simple it is better that icons/images can be changed the same way.

@lokonli
Copy link
Collaborator

lokonli commented Sep 27, 2019

Progressing.
Finished the general framework. Updated streamplayer, frame and news.
After I've finalized the other 'special' blocks (publictransport, traffic, longfonds) I'll merge it into beta.

@lokonli
Copy link
Collaborator

lokonli commented Nov 9, 2019

Solved in v3.2.0 beta.

See #108

@lokonli lokonli closed this as completed Nov 9, 2019
@abaratian
Copy link

no, still the image/icon for thermostat cannot be changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants