Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Capacitor App stack traces #645

Closed
stripathix opened this issue Dec 13, 2020 · 2 comments · Fixed by #685
Closed

Support for Capacitor App stack traces #645

stripathix opened this issue Dec 13, 2020 · 2 comments · Fixed by #685
Labels
enhancement New feature or request

Comments

@stripathix
Copy link

I am moving from sentry to datadog for error logging. I have an Ionic + Capacitor application. So this application runs as a Hybrid Application. Same source code is used for both Web Application, iOS, and Android.

The problem that I am getting when running as an iOS app is that stacktrace does not contain the proper file name and line number where the error occurred.

JS code that is throwing the error is:

// newTestVariableis not declared ever.
var a = newTestVariable;

Log created is:
Screenshot 2020-12-13 at 8 34 47 PM

A similar issue was earlier in Sentry also which was reported here getsentry/sentry-javascript#1863 and they resolved it by modifying their gecko here mrlowe/sentry-javascript@3a09f91. So it might be helpful to understand what I mean.

Maybe something similar needs to be done by datadog also.

@bcaudan
Copy link
Contributor

bcaudan commented Dec 14, 2020

Hello @stripathix,

Thanks for all the context, it should indeed be something similar.
We'll look into it and get back to you.

@bcaudan bcaudan added the enhancement New feature or request label Dec 14, 2020
@bcaudan bcaudan changed the title Error stack created at Capacitor App is facing same issue as Sentry was used to face Support for Capacitor App stack traces Dec 14, 2020
@bcaudan
Copy link
Contributor

bcaudan commented Jan 21, 2021

👋 @stripathix, we've added the support with 2.3.0 version, let us know how it goes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants