[service] Avoid failures of service resource with frequent restarts
#469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Happens on systemd-based systems since systemd applies its limits on the number of restarts of a service (by default, 5 times starts every 10 seconds) on both the user-requested restarts and the ones systemd does on its own (when the service fails starting for instance). Root of the problem is that the service resource in `datadog_monitor` is different from the one in the main chef run (chef limitation), so the restarts that happen there are done immediately instead of being queued up nicely at the end of the global chef run. If multiple invocations of this resource are updated in a chef run the restart limit of systemd can be quickly reached. A better fix would be to remove the service definition from `datadog_monitor` and make all invocations of `datadog_monitor` notify the global `service[datadog-agent]` resource. This would be a breaking change, let's do it for the next major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #467 (see description there)