Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for extraction of B3 headers #50

Closed
stroem opened this issue Nov 19, 2020 · 4 comments
Closed

Support for extraction of B3 headers #50

stroem opened this issue Nov 19, 2020 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@stroem
Copy link

stroem commented Nov 19, 2020

Would like to have support for extracing incomming B3 headers.
Current solution only parses xray and datadog trace id and span id.

Suggestion is to use the implementation found in dd-trace-go/tracer using env variables DD_PROPAGATION_STYLE_EXTRACT

@stroem
Copy link
Author

stroem commented Nov 20, 2020

Would also be good to bump dd-trace-go/tracer to get support for 128 bits B3 trace ids
See DataDog/dd-trace-go@b9e8e8c

@DarcyRaynerDD DarcyRaynerDD added the enhancement New feature or request label Aug 16, 2021
@DarcyRaynerDD
Copy link
Collaborator

Hi @stroem, sorry for the late replay. We haven't prioritized any work on adding this to datadog-lambda-go, but we will continue to leave the issue open and see if it gains enough community attention. We would be happy to look at a PR adding b3 header support.

@duncanista
Copy link
Contributor

@purple4reina was this fixed in #150?

@duncanista
Copy link
Contributor

duncanista commented Jan 9, 2024

Hey @stroem – sorry for taking so long to take a look at this.

-- edit:

Wow, our docs our outdated, I'm going to pass it on to our team! I found the Go specific doc which suggests that you can indeed just use DD_TRACE_PROPAGATION_STYLE=B3 and it should work, since our Datadog Lambda Extension (in charge of inferring spans for some runtimes, like Go) already allows this.

--

As per the tracing propagation style docs I noticed this is not inherently available yet in Datadog's Go tracer.

For us to better triage this issue, please make sure to submit a feature request ticket in our support platform mentioning this ticket – you could also submit a ticket in the tracer's repository. Since this Library depends on tracing propagation from it, it's best to address it there!

I'm going to close the ticket, but feel free to re-open if you have any questions, or concerns!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants