[branch-50]: fix: Add overflow checks to SparkDateAdd/Sub to avoid panics (apache#18013) (apache#18131)

## Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases.
You can link an issue to this PR using the GitHub syntax. For example
`Closes apache#123` indicates that this PR will close issue apache#123.
-->

- Related to apache/datafusion-comet#2539
- Related to apache#18072

## Rationale for this change

<!--
Why are you proposing this change? If this is already explained clearly
in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand
your changes and offer better suggestions for fixes.
-->

Return errors rather than panicking.

## What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it
is sometimes worth providing a summary of the individual changes in this
PR.
-->

## Are these changes tested?

<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code

If tests are not included in your PR, please explain why (for example,
are they covered by existing tests)?
-->

## Are there any user-facing changes?

<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->

<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->

Co-authored-by: Andy Grove <agrove@apache.org>
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>

Author: 3 people

datafusion/spark/src/function/datetime/date_add.rs

@@ -21,6 +21,7 @@ use std::sync::Arc;
 use arrow::array::ArrayRef;
 use arrow::compute;
 use arrow::datatypes::{DataType, Date32Type};
+use arrow::error::ArrowError;
 use datafusion_common::cast::{
     as_date32_array, as_int16_array, as_int32_array, as_int8_array,
 };
@@ -96,26 +97,38 @@ fn spark_date_add(args: &[ArrayRef]) -> Result<ArrayRef> {
     let result = match days_arg.data_type() {
         DataType::Int8 => {
             let days_array = as_int8_array(days_arg)?;
-            compute::binary::<_, _, _, Date32Type>(
+            compute::try_binary::<_, _, _, Date32Type>(
                 date_array,
                 days_array,
-                |date, days| date + days as i32,
+                |date, days| {
+                    date.checked_add(days as i32).ok_or_else(|| {
+                        ArrowError::ArithmeticOverflow("date_add".to_string())
+                    })
+                },
             )?
         }
         DataType::Int16 => {
             let days_array = as_int16_array(days_arg)?;
-            compute::binary::<_, _, _, Date32Type>(
+            compute::try_binary::<_, _, _, Date32Type>(
                 date_array,
                 days_array,
-                |date, days| date + days as i32,
+                |date, days| {
+                    date.checked_add(days as i32).ok_or_else(|| {
+                        ArrowError::ArithmeticOverflow("date_add".to_string())
+                    })
+                },
             )?
         }
         DataType::Int32 => {
             let days_array = as_int32_array(days_arg)?;
-            compute::binary::<_, _, _, Date32Type>(
+            compute::try_binary::<_, _, _, Date32Type>(
                 date_array,
                 days_array,
-                |date, days| date + days,
+                |date, days| {
+                    date.checked_add(days).ok_or_else(|| {
+                        ArrowError::ArithmeticOverflow("date_add".to_string())
+                    })
+                },
             )?
         }
         _ => {

datafusion/spark/src/function/datetime/date_sub.rs

@@ -21,6 +21,7 @@ use std::sync::Arc;
 use arrow::array::ArrayRef;
 use arrow::compute;
 use arrow::datatypes::{DataType, Date32Type};
+use arrow::error::ArrowError;
 use datafusion_common::cast::{
     as_date32_array, as_int16_array, as_int32_array, as_int8_array,
 };
@@ -90,26 +91,38 @@ fn spark_date_sub(args: &[ArrayRef]) -> Result<ArrayRef> {
     let result = match days_arg.data_type() {
         DataType::Int8 => {
             let days_array = as_int8_array(days_arg)?;
-            compute::binary::<_, _, _, Date32Type>(
+            compute::try_binary::<_, _, _, Date32Type>(
                 date_array,
                 days_array,
-                |date, days| date - days as i32,
+                |date, days| {
+                    date.checked_sub(days as i32).ok_or_else(|| {
+                        ArrowError::ArithmeticOverflow("date_sub".to_string())
+                    })
+                },
             )?
         }
         DataType::Int16 => {
             let days_array = as_int16_array(days_arg)?;
-            compute::binary::<_, _, _, Date32Type>(
+            compute::try_binary::<_, _, _, Date32Type>(
                 date_array,
                 days_array,
-                |date, days| date - days as i32,
+                |date, days| {
+                    date.checked_sub(days as i32).ok_or_else(|| {
+                        ArrowError::ArithmeticOverflow("date_sub".to_string())
+                    })
+                },
             )?
         }
         DataType::Int32 => {
             let days_array = as_int32_array(days_arg)?;
-            compute::binary::<_, _, _, Date32Type>(
+            compute::try_binary::<_, _, _, Date32Type>(
                 date_array,
                 days_array,
-                |date, days| date - days,
+                |date, days| {
+                    date.checked_sub(days).ok_or_else(|| {
+                        ArrowError::ArithmeticOverflow("date_sub".to_string())
+                    })
+                },
             )?
         }
         _ => {

datafusion/sqllogictest/test_files/spark/datetime/date_add.slt

@@ -45,6 +45,22 @@ SELECT date_sub('2016-07-30'::date, 0::int);
 ----
 2016-07-30
 
+query error DataFusion error: Arrow error: Arithmetic overflow: date_add
+SELECT date_add('2016-07-30'::date, 2147483647::int);
+
+query error DataFusion error: Arrow error: Arithmetic overflow: date_sub
+SELECT date_sub('1969-01-01'::date, 2147483647::int);
+
+query D
+SELECT date_add('2016-07-30'::date, 100000::int);
+----
+2290-05-15
+
+query D
+SELECT date_sub('2016-07-30'::date, 100000::int);
+----
+1742-10-15
+
 # Test with negative day values (should subtract days)
 query D
 SELECT date_add('2016-07-30'::date, -5::int);