Adding gnupg to allow install on debian 9 and a warning if dirmngr is not installed #191
Conversation
There was a problem hiding this comment.
Thanks for addressing this 👍
Made a couple of comments.
Also, we can re-discuss in the future if it's worth separating the debian and ubuntu packages (given our current build system it might be a bit too complex for what we actually need). We only need apt-key to install the new APT key, when we switch to the new key (which could happen for the next major version of the agent for instance) we should be able to remove apt-key entirely from our install scripts
| echo " ... OK" | ||
| else | ||
| echo " ... failed" | ||
| if [ -f "/etc/debian_version" ] || [ "$DISTRIBUTION" = "Debian" ]; then |
There was a problem hiding this comment.
since /etc/debian_version is also present on Ubuntu, this condition will also be true on Ubuntu.
I think we can either:
- only use the
$DISTRIBUTIONvalue, which should work as long aslsb_releaseis actually present on the system (we can enforce that by declaringlsb-releaseas a dependency of the package), or - change the error message a bit, to something like:
If you're running Debian 9, [...]
Honestly I think option 2. is enough :)
| else | ||
| echo " ... failed" | ||
| if [ -f "/etc/debian_version" ] || [ "$DISTRIBUTION" = "Debian" ]; then | ||
| echo "The dirmngr package is needed to add a new key to APT on Debian since version 9" |
There was a problem hiding this comment.
What do you think about adding more details here on the consequences of failing to add the new APT key. Something like: WARNING: The "dirmngr" package is needed to install the new APT key required by future versions of the Agent. If this package is not installed, please install it and then re-install the agent. The agent installation may break in the future if the new APT key is not installed on your system
hush-hush
force-pushed
the
maxime/debian-gnupg
branch
from
987fca7 to
fd53991
Compare
… not installed. We don't enforce dependency to dirmngr on the .deb package since it's shared between ubuntu and debian and it's only available in the 'universe' repo in ubuntu <= 14.04.
hush-hush
force-pushed
the
maxime/debian-gnupg
branch
from
fd53991 to
bf72b4c
Compare
We don't enforce dependency to dirmngr on the .deb package since it's
shared between ubuntu and debian and it's only available in the
'universe' repo in ubuntu <= 14.04.
Packaging for debian and ubuntu will be split in future version of the
agent.
see: DataDog/dd-agent#3397