[centos] Improve systemd and service restart behaviors #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The posttrans script runs for installs/upgrades on CentOS, that's the only place where we should restart the agent.
Same unit file and start script as debian and suse packages.
|
Just tested this on a CentOS 5 VM, it works well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on DataDog/dd-agent#3477
Improves service restart logic in installation scripts: on CentOS instead of restarting the agent service both in
postinstandposttrans, only restart it inposttrans, and make sure adatadog.conffile is present before doing so.Adds a systemd unit file: CentOS versions that use systemd (>= CentOS 7) will use it instead of the
init.dscript for lifecycle commands (start/stop/restart): same unit file and bash script as what's already used on debian.On a customer's environment with CentOS 7, using a systemd unit file has been way more reliable than relying on systemd's conversion of the
init.dscript, so let's ship it with the regular RPM pkg.These changes pass
dd-agent-testing. I haven't done much manual testing but if someone feels we should I can do that.