Support EC2 tag discovery in all regions #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AWS EC2 tag discovery defaulted to us-east-1. Support instance tag discovery in all regions by querying the instance-identity document store for the region and using `boto.ec2.connect_to_region`
|
Thanks a bunch a @mweagle ! Our master branch is currently frozen for the preparation of our 5.2.0 release. We'll review your pull request for our 5.3.0 release. |
|
Looks good to me ! Merging. |
remh
pushed a commit
that referenced
this pull request
Mar 16, 2015
Support EC2 tag discovery in all regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AWS EC2 tag discovery defaulted to us-east-1 which resulted in an instance discovery failure in other regions. The /var/log/datadog/collector.log was showing entries as in:
Support instance tag
discovery in all regions by querying the instance-identity document
store for the region and using
boto.ec2.connect_to_regionfor the EC2 instance discovery.NOTE: Apologies in advance for Python style violations...I've not used Python in a long time and I'm not in a position to setup a full test environment. Thanks!