[Jenkins] supporting the new folder naming convention #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkaj
changed the title
| # versions of Jenkins > 1.597 need to be sorted by build number (integer) | ||
| try: | ||
| dirs = sorted(dirs, key=lambda x: int(x.split('/')[-1]), reverse=True) | ||
| except: |
There was a problem hiding this comment.
You should almost never use bare "except:" as it would also catch System exiting exceptions which you don't want.
You should use except Exception or even better catch the actual exceptions that can be raised here.
hkaj
force-pushed
the
haissam/jenkins-new-folder-format
branch
from
ce5334d to
756ed60
Compare
| build_file = os.path.join(dir_name, 'build.xml') | ||
|
|
||
| if not os.access(build_file, os.R_OK): | ||
| self.log.debug("Can't read build file at %s" % (build_file)) |
|
One last thing is that now you'll parse the build.xml twice. One to get the timestamp and one to get the other metadata, can you consolidate this ? Looks good otherwise! |
hkaj
force-pushed
the
haissam/jenkins-new-folder-format
branch
from
bac7616 to
26acdb3
Compare
| # We try to get the last valid build | ||
| for index in xrange(0, len(dirs) - 1): | ||
| for index in xrange(len(dirs)): |
There was a problem hiding this comment.
Nice bug fix!
We should likely just do:
for dir_name in dirs:unless i'm missing something ?
hkaj
force-pushed
the
haissam/jenkins-new-folder-format
branch
from
26acdb3 to
f223822
Compare
hkaj
force-pushed
the
haissam/jenkins-new-folder-format
branch
from
f223822 to
5bc5224
Compare
remh
pushed a commit
that referenced
this pull request
Mar 18, 2015
[Jenkins] supporting the new folder naming convention
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from v1.597, the build folder names are not named with a timestamp anymore but with an ID. We have to get the timestamp from the
build.xmlfile and to use the folder name to guess the build number.