[Supervisord]Make sure to always send the can_connect service check #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| message='Supervisor server %s is down.' % server_name) | ||
| self.service_check(SERVER_SERVICE_CHECK, AgentCheck.CRITICAL, | ||
| tags=server_service_check_tags, | ||
| message=msg) |
There was a problem hiding this comment.
Not yours, but line 81 of the msg assignment, typo: "make sure sure"
|
Otherwise LGTM, merge away. |
|
Cancelled the CI, as it already passed it w/o the typo. |
remh
pushed a commit
that referenced
this pull request
Apr 7, 2015
[Supervisord]Make sure to always send the can_connect service check
remh
pushed a commit
that referenced
this pull request
Apr 7, 2015
I changed the error message in #1512 but didn’t change the test accordingly. This fixes that issue.
remh
pushed a commit
that referenced
this pull request
Apr 7, 2015
I changed the error message in #1512 but didn’t change the test accordingly. This fixes that issue.
remh
pushed a commit
that referenced
this pull request
Apr 7, 2015
I changed the error message in #1512 but didn’t change the test accordingly. This fixes that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.