[disk] AgentCheck for Disk metrics 🎉 #1596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
degemer
force-pushed
the
quentin/disk-check-filesystem
branch
2 times, most recently
from
dcd56e1 to
85b24b2
Compare
degemer
changed the title
degemer
force-pushed
the
quentin/disk-check-filesystem
branch
8 times, most recently
from
4be7581 to
25d3acc
Compare
| list devices. A 'device' is a list with fields corresponding to the | ||
| output of df output on each platform. | ||
| """ | ||
| all_devices = [l.strip().split() for l in df_output.split("\n")] |
There was a problem hiding this comment.
I know it doesn't matter in this case as it's only for linux but you should use:
df_output.splitlines()instead. It's better practice as it should work on all platforms.
degemer
force-pushed
the
quentin/disk-check-filesystem
branch
2 times, most recently
from
bd11bf1 to
cba96b7
Compare
|
I addressed all your comments, moved
|
degemer
force-pushed
the
quentin/disk-check-filesystem
branch
from
cba96b7 to
4d31fd1
Compare
|
Thanks for making the updates. Merging. |
This commit is the first step towards the annihilation of the old `Check`
hidden in `checks/system/{unix,win32}.py`!
It's time to launch the final assault of `Check`. `AgentCheck` shall triumph!
Add a `checks.d/disk.py` checks, which uses psutil when available to get
disk metrics (same than the previous `disk` checks), and otherwise
get the same metrics with `df`.
It has a small integration test, just to check that metrics exist, and
more precise mock tests.
This new check is enabled by default, and the old `disk` checks are
disabled.
LeoCavaille
force-pushed
the
quentin/disk-check-filesystem
branch
from
4d31fd1 to
c85eadf
Compare
|
Changes Unknown when pulling c85eadf on quentin/disk-check-filesystem into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit is the first step towards the annihilation of the old
Checkhidden in
checks/system/{unix,win32}.py!It's time to launch the final assault of
Check.AgentCheckshall triumph!Add a
checks.d/disk.pychecks, which uses psutil when available to getdisk metrics (same than the previous
diskchecks), and otherwiseget the same metrics with
df.It has a small integration test, just to check that metrics exist, and
more precise mock tests.
This new check is enabled by default, and the old
diskchecks aredeleted.
Fix #568