[checks] Handle requests raised timeouts in http_check #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, Can we refactor this part of the code ? Looks like we could catch these 3 exceptions at once. |
hkaj
force-pushed
the
haissam/http_check_exception
branch
from
71be407 to
e780ca8
Compare
|
thanks for the suggestion @remh, it's done |
remh
pushed a commit
that referenced
this pull request
Jul 15, 2015
[checks] Handle requests raised timeouts in http_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug reported by a customer where the service check wasn't set to DOWN since the exception was caught by the last, general except.