Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flare][windows] Mention path to tar file in flare's UI #2084

Merged
merged 1 commit into from
Nov 16, 2015

Conversation

olivielpeau
Copy link
Member

Especially useful because the path of the temp dir on Windows where the tar is saved can vary from machine to machine.

@olivielpeau olivielpeau added this to the 5.7.0 milestone Nov 16, 2015
@olivielpeau olivielpeau force-pushed the olivielpeau/win-flare-print-tar-path branch from a233874 to 41cdafe Compare November 16, 2015 18:42
@olivielpeau
Copy link
Member Author

And btw, I've tested it on a windows build and it works well :)

return
try:
case_id = f.upload(email=str(email))
info_popup("Your logs were successfully uploaded. For future reference,"
" your internal case id is {0}".format(case_id))
except Exception, e:
warning_popup('The upload failed:\n{0}'.format(str(e)))
warning_popup('The upload failed. Please send the following file by email'
' to support: {0}\n\n{1}'.format(f.tar_path, str(e)))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we maybe add the email here, for convenience?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could, the only thing is that the customer may have a case already opened, in that case he/she should rather add the tar to the existing case and not send it directly to support's email...

@truthbk
Copy link
Member

truthbk commented Nov 16, 2015

Other than the minor comment about adding the email address for customer convenience - this looks 👍

@truthbk
Copy link
Member

truthbk commented Nov 16, 2015

👍

@olivielpeau
Copy link
Member Author

Thanks @truthbk! Will merge once the CI passes.

olivielpeau added a commit that referenced this pull request Nov 16, 2015
…-path

[flare][windows] Mention path to tar file in flare's UI
@olivielpeau olivielpeau merged commit f4e2389 into master Nov 16, 2015
@olivielpeau olivielpeau deleted the olivielpeau/win-flare-print-tar-path branch November 16, 2015 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants