-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flare][windows] Mention path to tar file in flare's UI #2084
Conversation
a233874
to
41cdafe
Compare
And btw, I've tested it on a windows build and it works well :) |
return | ||
try: | ||
case_id = f.upload(email=str(email)) | ||
info_popup("Your logs were successfully uploaded. For future reference," | ||
" your internal case id is {0}".format(case_id)) | ||
except Exception, e: | ||
warning_popup('The upload failed:\n{0}'.format(str(e))) | ||
warning_popup('The upload failed. Please send the following file by email' | ||
' to support: {0}\n\n{1}'.format(f.tar_path, str(e))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we maybe add the email here, for convenience?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, the only thing is that the customer may have a case already opened, in that case he/she should rather add the tar to the existing case and not send it directly to support's email...
Other than the minor comment about adding the email address for customer convenience - this looks 👍 |
👍 |
Thanks @truthbk! Will merge once the CI passes. |
…-path [flare][windows] Mention path to tar file in flare's UI
Especially useful because the path of the temp dir on Windows where the tar is saved can vary from machine to machine.