Minerkasch/yarn #2147
Minerkasch/yarn #2147
Conversation
|
|
||
| # Cluster metrics for YARN | ||
| YARN_CLUSTER_METRICS = { | ||
| 'appsSubmitted': ('yarn.metrics.appsSubmitted', GAUGE), |
There was a problem hiding this comment.
The usual datadog metrics name don't use camelCase usually but camel_case.
|
Thanks that's a pretty nice first version! Nicely written and easy to read! Can you ping me when the comments made are fixed please ? Thanks again |
|
Retrigered the ZK and ES. I dont think they failed a result of this PR. |
|
|
||
| # Get properties from conf file | ||
| rm_address = instance.get('resourcemanager_uri', DEFAULT_RM_URI) | ||
| self._timeout = int(instance.get('timeout', DEFAULT_TIMEOUT)) |
There was a problem hiding this comment.
You shouldn't store instance level setting at the check level.
|
Thanks a lot @wjsl Especially regarding the commit messages. Can you squash your commits into one and also write a more descriptive PR message ? Thanks again! |
zachradtka
force-pushed
the
minerkasch/yarn
branch
from
e5f5241 to
e1e17f3
Compare
|
Squashed and updated the commit message. Anything else? |
|
I looked at the TravisCI failure and they seem to be related to ZK, which we shouldn't be touching. Anything on our end we can do to get this PR closed? |
|
Thanks @wjsl @zachradtka added one last comment. |
zachradtka
force-pushed
the
minerkasch/yarn
branch
2 times, most recently
from
11412c3 to
d6f7fe3
Compare
zachradtka
force-pushed
the
minerkasch/yarn
branch
from
d6f7fe3 to
3a363a5
Compare
PR contains a dd-agent check for YARN clusters.