Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http_check] Add an option to disable warnings when disabling ssl val… #2193

Merged
merged 1 commit into from
Jan 12, 2016
Merged

[http_check] Add an option to disable warnings when disabling ssl val… #2193

merged 1 commit into from
Jan 12, 2016

Conversation

remh
Copy link

@remh remh commented Jan 11, 2016

…idation

@remh remh added this to the 5.7.0 milestone Jan 11, 2016
@olivielpeau
Copy link
Member

👍

@olivielpeau
Copy link
Member

Hum actually this test needs to be updated with the additional parameter:

dd-agent/tests/checks/integration/test_http_check.py

Line 176 in 1c977e5

instance_ca_certs, weakciphers = self.check._load_conf(CONFIG_HTTP_HEADERS['instances'][0])

@remh remh force-pushed the remh/ignore_ssl_warning branch from 98aa162 to 065ee0e Compare January 12, 2016 16:49
@remh
Copy link
Author

remh commented Jan 12, 2016

Fixed. CI should pass now. Thanks @olivielpeau

remh pushed a commit that referenced this pull request Jan 12, 2016
Merge pull request #2193 from DataDog/remh/ignore_ssl_warning
28c2ea2 
[http_check] Add an option to disable warnings when disabling ssl val…
@remh remh merged commit 28c2ea2 into master Jan 12, 2016
@remh remh deleted the remh/ignore_ssl_warning branch January 12, 2016 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@remh @olivielpeau