Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove etcd flake #2205

Merged
merged 1 commit into from
Jan 15, 2016
Merged

Remove etcd flake #2205

merged 1 commit into from
Jan 15, 2016

Conversation

ojongerius
Copy link
Contributor

Should fix #2204

@ojongerius
casecmp will return '-1' in this case, which in certain version of Ru…
e1a133c 
…by will be considered to be true. Thanks rubucop.
@truthbk truthbk added this to the Triage milestone Jan 15, 2016
@truthbk
Copy link
Member

truthbk commented Jan 15, 2016

@ojongerius thank you very much for this! We'll double-check and merge soon, very much appreciated.

@remh
Copy link

remh commented Jan 15, 2016

Thanks !

remh pushed a commit that referenced this pull request Jan 15, 2016
Merge pull request #2205 from atlassian/etcd_build_fail
69e370e 
Remove etcd flake
@remh remh merged commit 69e370e into DataDog:master Jan 15, 2016
@ojongerius ojongerius deleted the etcd_build_fail branch January 15, 2016 23:45
@olivielpeau olivielpeau modified the milestones: 5.7.0, Triage Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.7.0
Development

Successfully merging this pull request may close these issues.

Etcd flake
4 participants
@ojongerius @truthbk @remh @olivielpeau