[teamcity] Add basic_http_authentication support #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mderomph-coolblue
force-pushed
the
master
branch
from
b6f26a7 to
d0d0595
Compare
|
Bump, anybody that could merge this? |
| @@ -10,10 +10,14 @@ instances: | |||
| # Specify the server name of your teamcity instance here | |||
| # Guest authentication must be on if you want the check to be able to get data | |||
| server: teamcity.mycompany.com | |||
There was a problem hiding this comment.
Could you mention here that when basic auth is used the username and password need to be provided in the server parameter in the user:password@server format?
|
Hi @mderomph-coolblue, thanks for your contribution! I had a quick look at your PR and had only one comment for now, could you address it please? We'll be sure to review your PR in details soon. |
mderomph-coolblue
force-pushed
the
master
branch
from
0e0cf1f to
c049b9c
Compare
|
Passed all the test now, hope you guys can take a look at it. Thanks! |
|
Is there anythings else I can do to get this pull request merged? |
|
Looks good to me. Thanks! |
remh
pushed a commit
that referenced
this pull request
Mar 22, 2016
[teamcity] Add basic_http_authentication support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.