Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[disk] add a regex option to exclude disks based on mountpoint #2359

Merged
merged 1 commit into from
Apr 25, 2016
Merged

[disk] add a regex option to exclude disks based on mountpoint #2359

merged 1 commit into from
Apr 25, 2016

Conversation

rhwlo
Copy link

@rhwlo rhwlo commented Mar 17, 2016

summary

This changeset adds an exclude_mountpoint_re option the disk integration configuration and corrects a small typo in the disk integration configuration template.

motivation

Nagios’s check_disk plugin has a -i option to ignore paths or partitions based off of regular expressions, and this will add the same functionality to Datadog.

testing

I’ve added tests to mock/test_disk.py alongside the other disk tests to verify that the regexes exclude what we want and nothing else.

@olivielpeau
Copy link
Member

Thanks @rhwlo for the PR, we'll be sure to review and test it soon. At first glance it looks great!

@remh remh modified the milestones: 5.8.0, Triage Apr 25, 2016
@remh remh self-assigned this Apr 25, 2016
@remh
Copy link

remh commented Apr 25, 2016

That looks great, thanks!

@remh remh merged commit 6e66e4b into DataDog:master Apr 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants