[k8s] Add pods created by ReplicaSet to .pods.running metric #2446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crunchie84 thanks a lot for this PR, we will review soon. |
remh
pushed a commit
that referenced
this pull request
May 17, 2016
remh
pushed a commit
that referenced
this pull request
May 17, 2016
remh
pushed a commit
that referenced
this pull request
May 17, 2016
- Enable kubelet check by default - Remove master check for now as they are flaky, hard to enable and not used - Adapt to new format of labels set by kube1.2 fix #2388 #2494 - Allow to blacklist labels - Support replica sets fix #2444 #2446 - Handle case where no pods are running. Fix #2263 - Add tests for kube 1.2
remh
pushed a commit
that referenced
this pull request
May 17, 2016
- Enable kubelet check by default - Remove master check for now as they are flaky, hard to enable and not used - Adapt to new format of labels set by kube1.2 fix #2388 #2494 - Allow to blacklist labels - Support replica sets fix #2444 #2446 - Handle case where no pods are running. Fix #2263 - Add tests for kube 1.2
remh
pushed a commit
that referenced
this pull request
May 17, 2016
- Enable kubelet check by default - Remove master check for now as they are flaky, hard to enable and not used - Adapt to new format of labels set by kube1.2 fix #2388 #2494 - Allow to blacklist labels - Support replica sets fix #2444 #2446 - Handle case where no pods are running. Fix #2263 - Add tests for kube 1.2
remh
pushed a commit
that referenced
this pull request
May 18, 2016
- Enable kubelet check by default - Remove master check for now as they are flaky, hard to enable and not used - Adapt to new format of labels set by kube1.2 fix #2388 #2494 - Allow to blacklist labels - Support replica sets fix #2444 #2446 - Handle case where no pods are running. Fix #2263 - Add tests for kube 1.2
|
Closing in favor of #2512 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #2444