[mysql] improving accuracy for query exec time. Fixes issue #2406. #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
changed the title
| @@ -1188,7 +1188,7 @@ def _query_exec_time_per_schema(self, db): | |||
| # Fetches the avg query execution time per schema and returns the | |||
| # value in microseconds | |||
|
|
|||
| sql_avg_query_run_time = """SELECT schema_name, SUM(count_star) cnt, ROUND(AVG(avg_timer_wait)/1000000) AS avg_us | |||
| sql_avg_query_run_time = """SELECT schema_name, SUM(count_star) cnt, ROUND((SUM(sum_timer_wait) / SUM(count_star)) / 1000000) AS avg_us | |||
There was a problem hiding this comment.
kind of unrelated, but we could remove SUM(count_star) cnt from the SELECT as we don't use it right?
|
Had only one comment, feel free to ignore it though. Looks good to me! 👍 |
[mysql] removing unnecessary element from SQL query.
truthbk
force-pushed
the
jaime/mysql_avgfix
branch
from
3b51056 to
c7ff17a
Compare
|
Addressed @olivielpeau comment. Tested, CI tests passing, so merging. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2406.
ROUND((SUM(sum_timer_wait) / SUM(count_star)) / 1000000): represents the real averagetimer_waitper query for a given schema. Here,sum_timer_waitrepresents the sum of alltimer_waittimes for a certain query, andcount_staris the number of times a certain query was run.ROUND(AVG(avg_timer_wait)/1000000)actually represented the average of averages.The discrepancy between the two computations may be considerable.