[mapreduce] Consolidate tags #2474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for your contribution! We'll review and test this very soon, but it looks pretty good. The failing test looks unrelated, so I wouldn't worry about that. |
| # Get the cluster name from the conf file | ||
| cluster_name = instance.get('cluster_name') | ||
| if cluster_name is None: | ||
| raise Exception('The cluster_name must be specified in the instance configuration') |
There was a problem hiding this comment.
same comment as the YARN check, it'd be better to add a warning and set a default value instead of raising an exception.
|
@zachradtka Looks pretty good, only had one comment similar to my suggestion on the yarn PR. |
|
@olivielpeau I have updated the check and tests to remove the |
|
Thanks @zachradtka, looks good, can you squash your commits please? |
zachradtka
force-pushed
the
minerkasch/mapreduce-consolidate-tags
branch
from
67d0208 to
36d37a5
Compare
|
Thanks! Merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly a bugfix to reduce the number of tags collected with the MapReduce agent check.
The major fixes are:
cluster_nameinstead ofcluster_id