[mysql] fix replication service check. #2603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -535,17 +535,17 @@ def _collect_metrics(self, host, db, tags, options, queries): | |||
| # slaves will only be collected iff user has PROCESS privileges. | |||
| slaves = self._collect_scalar('Slaves_connected', results) | |||
|
|
|||
| if slave_running is not None: | |||
| if slave_running and not slaves: # slave | |||
There was a problem hiding this comment.
It think slaves can only be a float, wouldn't it be better to do a slaves == 0. ?
There was a problem hiding this comment.
It can also be a , so I'll fix that, good catch.None
|
👍 |
[mysql] fixing comparisons, slaves will be a float.
truthbk
force-pushed
the
jaime/mysql_replfix
branch
from
ffddf47 to
e614fa0
Compare
| slave_running_status = AgentCheck.OK | ||
| else: | ||
| slave_running_status = AgentCheck.WARNING | ||
| else: | ||
| slave_running_status = AgentCheck.CRITICAL |
There was a problem hiding this comment.
if on standalone, they should obviously disable replication on the YAML. But this would still make sense.
|
Way easier to read, thanks @truthbk! |
|
Thank you @degemer ! |
yannmh
added a commit
that referenced
this pull request
Feb 15, 2017
The `performance_schema.threads` table is not available on MySQL < `5.6.0`. As a result, retrieving the slaves' statuses triggers the following error: ``` ProgrammingError: (1146, u"Table 'performance_schema.threads' doesn't exist") ``` This is a regression introduced by #2603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The service check wasn't doing the right thing when running on the master. Should address issue #2596.
What
Couple things:
SELECT * FROM INFORMATION_SCHEMA.PROCESSLIST WHERE COMMAND LIKE '%Binlog dump%'because looking at the worker threads could be inaccurate (it's blocking though, but we should be fine).Slave_runningwill also be available on the master node, so we have to also check the number of slaves is 0 (or None). That should guarantee being on a slave, and not falling through that logic branch on a master (and thus report CRITICAL, when we're fine).For now we're keeping the replication check on the master in case a customer would like to run the
dd-agentjust on that node and still get replication insights.