kubernetes/kubeutil.py: Tag pods that are created by StatefulSets #3443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xvello
approved these changes
Jul 18, 2017
There was a problem hiding this comment.
Hi!
That looks good to me, thanks for your contribution! As 5.15 is in the release pipeline, I'm tagging this for 5.16. In the meantime are you OK building your own image overwriting kubeutil.py?
As for k_state, we already have a PR open for it: DataDog/integrations-core#561
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
This will tag pod metadata with
kube_stateful_set:<name>if they are members of a stateful set.Motivation
I ultimately want to be able to create timeboards and monitors on the diff between the
desiredandcurrentnumber of pods for a givenStatefulSet. I am currently doing something similar with the diff betweendesiredandavailablepods for a deployment. It is unclear to me if these changes are needed for the kube_state integration or not.Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
Anything else we should know when reviewing?