[win32] Remove run_check
#3448
Merged
[win32] Remove run_check
#3448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`run_check` dates back from pre-5.12 windows agents, when we weren't shipping a full python interpreter and needed this specific method to allow users to run custom checks from `shell.exe`. This doesn't make sense anymore now that we ship a full python interpreter that the agent processes use. That interpreter has the necessary modules to run checks. The correct way to run checks (shipped by default or custom) is now similar to Linux/macOS, i.e.: ``` From the `<install_dir>\agent` directory > ..\embedded\python.exe agent.py check <check_name> ``` `shell.exe` should only be used to troubleshoot the python environment that the windows service and the windows GUI use.
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes the
run_checkmethod.Motivation
run_checkdates back from pre-5.12 windows agents, when we weren'tshipping a full python interpreter and needed this specific method
to allow users to run custom checks from
shell.exe.This doesn't make sense anymore now that we ship a full python
interpreter that the agent processes use. That interpreter has the
necessary modules to run checks. The correct way to run checks
(shipped by default or custom) is now similar to Linux/macOS, i.e.:
shell.exeshould only be used to troubleshoot the python environmentthat the windows service and the windows GUI use.