[dogstatsd] Parse distribution metrics and ignore them #3458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of failing on known but unsupported metric types, ignore these metrics and continue parsing the rest of the packet. Without this, sending a new "distribution" type metric in a datagram makes dogstatsd drop the whole datagram. This change has virtually no impact on the performance of the dogstatsd parser.
hush-hush
approved these changes
Jul 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Parses
distributionmetrics and ignores them.Motivation
distributionis a new dogstatsd metric type that this implementation doesn'tsupport.
Instead of failing on known but unsupported metric types, ignore these
metrics and continue parsing the rest of the packet.
Without this, sending a new "distribution" type metric in a datagram
makes dogstatsd drop the whole datagram.
Additional Notes
This change has virtually no impact on the performance of the dogstatsd
parser.